Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Android build variables to env #9120

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Move Android build variables to env #9120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08377cb
Move Android build variables to env
AndrewGable May 20, 2022
66ecf7b
Add encrypted keystore and env variables from secrets
AndrewGable Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/platformDeploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ jobs:
- name: Run Fastlane beta
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
run: bundle exec fastlane android beta
env:
MYAPP_UPLOAD_STORE_PASSWORD: ${{ secrets.MYAPP_UPLOAD_STORE_PASSWORD }}
MYAPP_UPLOAD_KEY_PASSWORD: ${{ secrets.MYAPP_UPLOAD_KEY_PASSWORD }}


- name: Run Fastlane production
if: ${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
Expand Down
4 changes: 2 additions & 2 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,9 @@ android {
release {
if (project.hasProperty('MYAPP_UPLOAD_STORE_FILE')) {
storeFile file(MYAPP_UPLOAD_STORE_FILE)
storePassword MYAPP_UPLOAD_STORE_PASSWORD
storePassword System.getenv('MYAPP_UPLOAD_STORE_PASSWORD')
keyAlias MYAPP_UPLOAD_KEY_ALIAS
keyPassword MYAPP_UPLOAD_KEY_PASSWORD
keyPassword System.getenv('MYAPP_UPLOAD_KEY_PASSWORD')
}
}
debug {
Expand Down
Binary file modified android/app/my-upload-key.keystore.gpg
View file
Open in desktop
Binary file not shown.
2 changes: 0 additions & 2 deletions android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ FLIPPER_VERSION=0.100.0

# Key Store Information
MYAPP_UPLOAD_STORE_FILE=my-upload-key.keystore
MYAPP_UPLOAD_STORE_PASSWORD=jab-devalue-medley-quartet-ambition-demigod-shinbone-luster-inject-while

# Key Information
MYAPP_UPLOAD_KEY_ALIAS=ReactNativeChat-Key-Alias
MYAPP_UPLOAD_KEY_PASSWORD=pry-eave-cervix-deltoid-plaudit-bunting-larynges-octagon-jetliner-possum