-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify subscribers on the next tick #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves the endless spinner issue on login. Even with the redirect to /r, this seems like a good improvement to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but curious if we want to also make a similar change for merge()
, multiSet()
and mergeCollection()
? There are a few other methods that set data and also were calling keyChanged()
or keysChanged()
async before kid roca's changes.
Ah good call Marc, I can test adding those. That might solve some of the other issues I am seeing. |
Updated to notify the subscribers on the next tick for I did not notice any difference, however this better matches the prior behavior, and passes all tests. |
cc @kidroca @marcaaron
Details
This updates subscribers of data changes on the next tick, rather than blocking on notifying subscribers.
Related Issues
Expensify/App#3485 (comment)
Expensify/App#3488 (comment)
Automated Tests
Existing automated tests cover these changes.
Linked PRs
Expensify/App#3535