Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify subscribers on the next tick #82

Merged
merged 4 commits into from
Jun 11, 2021
Merged

Notify subscribers on the next tick #82

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0354f35
Notify subscribers on the next tick
Jun 11, 2021
ec9f777
Use Promise instead of setImmediate
Jun 11, 2021
cd8dcb6
Additional next tick notifications
Jun 11, 2021
a4401ba
Update comments
Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/Onyx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,8 +474,8 @@ function remove(key) {
// Cache the fact that the value was removed
cache.set(key, null);

// Optimistically inform subscribers
keyChanged(key, null);
// Optimistically inform subscribers on the next tick
Promise.resolve().then(() => keyChanged(key, null));

return AsyncStorage.removeItem(key);
}
Expand Down Expand Up @@ -516,8 +516,8 @@ function set(key, val) {
// Adds the key to cache when it's not available
cache.set(key, val);

// Optimistically inform subscribers
keyChanged(key, val);
// Optimistically inform subscribers on the next tick
Promise.resolve().then(() => keyChanged(key, val));

// Write the thing to persistent storage, which will trigger a storage event for any other tabs open on this domain
return AsyncStorage.setItem(key, JSON.stringify(val))
Expand Down Expand Up @@ -546,9 +546,9 @@ function multiSet(data) {
const keyValuePairs = prepareKeyValuePairsForStorage(data);

_.each(data, (val, key) => {
// Update cache and optimistically inform subscribers
// Update cache and optimistically inform subscribers on the next tick
cache.set(key, val);
keyChanged(key, val);
Promise.resolve().then(() => keyChanged(key, val));
});

return AsyncStorage.multiSet(keyValuePairs)
Expand Down