Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: if user not exists why i can list his URLS #94

Closed
mshannaq opened this issue Nov 15, 2023 · 1 comment · Fixed by #93
Closed

Bug: if user not exists why i can list his URLS #94

mshannaq opened this issue Nov 15, 2023 · 1 comment · Fixed by #93
Labels
bug Something isn't working
Milestone
1.0.0-dev

Comments

@mshannaq
Copy link
Member

Describe the bug
while the user 7789 is not exists why I can still list urls
eg: https://smartyurl.test/url/user/7789

image
@mshannaq mshannaq added the bug Something isn't working label Nov 15, 2023
@mshannaq
Copy link
Member Author

mshannaq commented Nov 16, 2023 •
edited
Loading

Yes I can see it in TODO , may be is missed by mistake

SmartyURL/app/Controllers/Url.php

Lines 77 to 78 in e6cfc70

// @TODO FIX ME I must make sure user is exists
// @TODO and make sure from permission

mshannaq added a commit that referenced this issue Nov 16, 2023
@mshannaq
fix: check if user not exists while list users urls #94
62c52b8
@mshannaq mshannaq linked a pull request Nov 16, 2023 that will close this issue
Local mshannaq work #93
Merged
7 tasks
@mshannaq mshannaq mentioned this issue Nov 16, 2023
Merged
7 tasks
@ghost ghost closed this as completed in #93 Nov 16, 2023
@mshannaq mshannaq added this to the 1.0.0-dev milestone Dec 11, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-dev
Development

Successfully merging a pull request may close this issue.

Local mshannaq work Extendy/SmartyURL
1 participant
@mshannaq