Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local mshannaq work #93

Merged
26 commits merged into from
Nov 16, 2023
Merged

Local mshannaq work #93

26 commits merged into from
Nov 16, 2023

Conversation

mshannaq
Copy link
Member

@mshannaq mshannaq commented Nov 13, 2023 •
edited
Loading

In this pull request (PR), the following actions take place:

  • add link to URL visits no on list URLS page.
  • Update IP2Location Database File.
  • never decode URLs Bug: url shown in encoded format #91. we should not touch URLs and we must store it as coming from user.
  • complete the delete url option, user can delete his own urls and admin.manageotherurls or super.admin can delete other urls also.
  • in list urls add delete button for every url.
  • modify English documentation.
  • fix Bug: if user not exists why i can list his URLS #94

@mshannaq mshannaq self-assigned this Nov 13, 2023
@mshannaq mshannaq requested a review from a user November 13, 2023 14:53
@mshannaq mshannaq added the enhancement New feature or request label Nov 13, 2023
@mshannaq mshannaq linked an issue Nov 13, 2023 that may be closed by this pull request
Bug: url shown in encoded format #91
Closed
@mshannaq mshannaq linked an issue Nov 14, 2023 that may be closed by this pull request
Feat: delete URL #89
Closed
@mshannaq mshannaq linked an issue Nov 16, 2023 that may be closed by this pull request
Bug: if user not exists why i can list his URLS #94
Closed
ghost
ghost approved these changes Nov 16, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@ghost ghost merged commit a74d222 into main Nov 16, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@mshannaq mshannaq

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: if user not exists why i can list his URLS Bug: url shown in encoded format Feat: delete URL
1 participant
@mshannaq