Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily add dialog with None tag to dialogs list #118

Merged
merged 2 commits into from
May 9, 2018
Merged

Conversation

ovv
Copy link
Contributor

@ovv ovv commented May 7, 2018

Some request can come without a To headers tag (after a 401 for
example). This should probably be done only for specific
status code.

Also catch asyncio.CancelledError of dialog._closing

Some request can come without a `To` headers tag (after a 401 for
example). This should probably be done only for specific
status code.
@ovv ovv force-pushed the dialog-tracking-2 branch from ffca318 to 3becf66 Compare May 7, 2018 12:59
@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #118 into master will increase coverage by 0.19%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   71.48%   71.68%   +0.19%     
==========================================
  Files          15       15              
  Lines        1487     1501      +14     
  Branches      256      257       +1     
==========================================
+ Hits         1063     1076      +13     
- Misses        316      317       +1     
  Partials      108      108
Impacted Files Coverage Δ
aiosip/application.py 72.61% <0%> (+0.45%) ⬆️
aiosip/peers.py 78.69% <100%> (+0.09%) ⬆️
aiosip/utils.py 46.8% <66.66%> (+3.21%) ⬆️
aiosip/dialog.py 76.25% <83.33%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2a81e...f4d0a5e. Read the comment docs.

ovv referenced this pull request May 7, 2018
@ovv ovv mentioned this pull request May 7, 2018
@ovv ovv merged commit 7c2bd36 into master May 9, 2018
@ovv ovv deleted the dialog-tracking-2 branch May 11, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants