Request #119
Open
Request #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some request can come without a `To` headers tag (after a 401 for example). This should probably be done only for specific status code.
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 71.48% 71.82% +0.33%
==========================================
Files 15 15
Lines 1487 1512 +25
Branches 256 257 +1
==========================================
+ Hits 1063 1086 +23
- Misses 316 318 +2
Partials 108 108
Continue to review full report at Codecov.
|
|
I really like it. I was always planning on going back to do this. As for #118 - I forgot app is attached to the request, so its actually really simple. |
|
I'm going to try merging this and #121 on a private branch and see how well it works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think of an approach like that for the
Request@vodik ?This is based on #118 only the last commit is relevant