Abort model cleanly in ifsinterface and standalone on errors #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f trying in clean end in case of namelist errors in oce_mesh
JanStreffing
requested changes
Jan 13, 2025
| ! TODO logic below is also convoluted really not really for standalone | ||
| #else ! | ||
| ! TODO logic below is convoluted, COMM that is passed should be used for MPI_ABORT | ||
| ! changes are easy but need to be tested with coupled configurations |
There was a problem hiding this comment.
Does that mean changes are were easy to make or would be easy?
| @@ -244,7 +244,7 @@ SUBROUTINE read_mesh(partit, mesh) | |||
| write (unit=error_unit, fmt='(3A)') & | |||
| '### error: can not open file ', file_name, & | |||
| ', error: ' // trim(errmsg) | |||
| call MPI_Abort(MPI_COMM_FESOM, 1, ierror) | |||
| !call MPI_Abort(MPI_COMM_FESOM, 1, ierror) # dont call abort here yet called bellow | |||
There was a problem hiding this comment.
Keep or remove fully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of old features lost in my branches that didn't make it into main, part 1.
TODO in another PR: