Create Basix elements directly, rather than going via UFL #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to mscroggs/basix-element
garth-wells
reviewed
Sep 23, 2022
| @@ -17,6 +17,8 @@ | |||
| import numpy as np | |||
| import numpy.typing as npt | |||
|
|
|||
| import basix | |||
| import basix.ufl_wrapper | |||
There was a problem hiding this comment.
Yes. As UFL is an optional dependency of Basix, this is not imported as part of basix by default to avoid errors for any users without UFL installed
| @@ -9,7 +9,10 @@ | |||
| import numpy as np | |||
| import numpy.typing as npt | |||
|
|
|||
| import basix | |||
| import basix.ufl_wrapper | |||
python/dolfinx/io/gmshio.py
Outdated
| return ufl.Mesh(ufl.VectorElement(scalar_element)) | ||
|
|
||
| element = basix.ufl_wrapper.create_vector_element( | ||
| "Lagrange", cell.cellname(), degree, basix.LagrangeVariant.equispaced, dim=gdim, gdim=gdim) |
There was a problem hiding this comment.
Is there a Basix enum for Lagrange?
There was a problem hiding this comment.
Yes, although the create_*_element convenience functions can also accept strings which are then converted using functions like basix.finite_element.string_to_family.
In this case, I've changed "Lagrange" to basix.ElementFamily.P
cell.cellname() is also a string, but I think it's best to leave it as so as the alternative is something ugly like attr(basix.CellType, cell.cellname())
garth-wells
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made functions in the Python interface use Basix's UFL wrapper rather than making UFL elements that FFCx will later convert to element from Basix's UFL wrapper.
This depends on FEniCS/ufl#117, FEniCS/basix#575, and FEniCS/ffcx#515.These have been merged now.