Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H inf sobolev space #117

Merged
merged 7 commits into from
Aug 23, 2022
Merged

H inf sobolev space #117

merged 7 commits into from
Aug 23, 2022

Conversation

dham
Copy link
Collaborator

@dham dham commented Aug 12, 2022

Define an HInf Sobolev space to contain the "R" space.

Cause apply_restrictions to use Sobolev space rather than a list of elements. This is an alternative to #109 .

Also clean up a few Sobolev space loose ends which appear to have drifted in along the way.

@dham dham mentioned this pull request Aug 12, 2022
Closed
@dham dham linked an issue Aug 12, 2022 that may be closed by this pull request
Real element should be in Cinfinity #114
Closed
@dham
Copy link
Collaborator Author

dham commented Aug 12, 2022

Firedrake tests for this running at firedrakeproject/firedrake#2522

@mscroggs mscroggs self-requested a review August 12, 2022 09:32
@mscroggs
Copy link
Member

mscroggs commented Aug 12, 2022 •
edited
Loading

DOLFINx tests are failing with "AttributeError: 'VectorElement' object has no attribute 'sobolev_space'". I guess VectorElements and other elements need to be given Sobolev spaces (or we do something like #109, but I agree that this approach is probably better)

@dham
Copy link
Collaborator Author

dham commented Aug 12, 2022

DOLFINx tests are failing with "AttributeError: 'VectorElement' object has no attribute 'sobolev_space'". I guess VectorElements and other elements need to be given Sobolev spaces (or we do something like #109, but I agree that this approach is probably better)

It's 2030 on Friday evening here so I'm not going to get to this until Monday, but VectorElement should inherit the Sobolev space of it's scalar element. TensorElement should do the same. Oh, and BrokenElement should always be L2, no matter what the space of the original element (that being the point of BrokenElement).

@mscroggs
Copy link
Member

It's 2030 on Friday evening here so I'm not going to get to this until Monday, but VectorElement should inherit the Sobolev space of it's scalar element. TensorElement should do the same. Oh, and BrokenElement should always be L2, no matter what the space of the original element (that being the point of BrokenElement).

I've just started working on this in #118 and I'm relieved that these are exactly what I just implemented

This was referenced Aug 12, 2022
Merged
Merged
Merged
@mscroggs
Copy link
Member

The DOLFINx tests pass in #118. @dham are you happy for me to merge that branch into this one?

@mscroggs
Add sobolev_space method to base finite element class (#118)
ac5bedf 
* Add nano swp files to .gitignore

* MAke finiteelementbase into an abstract base class and add sobolev_space method

* _

* restricted element is L2

* s

* make fenicsx tests run

* branches

* _ not -

* remove branch from test config

* max
wence-
wence- approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good

garth-wells
garth-wells approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for a future UFL: we need to start from 'domains', on which spaces are defined, to make proper sense of function spaces.

@garth-wells garth-wells merged commit 1951bee into main Aug 23, 2022
@garth-wells garth-wells deleted the h_inf_sobolev_space branch August 23, 2022 11:07
@mscroggs mscroggs mentioned this pull request Aug 23, 2022
Merged
pbrubeck pushed a commit to firedrakeproject/ufl that referenced this pull request Oct 10, 2022
@dham @mscroggs
@garth-wells @pbrubeck
H inf sobolev space (FEniCS#117)
6e284f2 
* Add a Sobolev space spanning C infinity elements.

* Put R space in HInf

* Test Sobolev space additions.

* Use Sobolev space as the restrictions check.

* Add sobolev_space method to base finite element class (FEniCS#118)

* Add nano swp files to .gitignore

* MAke finiteelementbase into an abstract base class and add sobolev_space method

* _

* restricted element is L2

* s

* make fenicsx tests run

* branches

* _ not -

* remove branch from test config

* max

* main fenics and ffc

Co-authored-by: Matthew Scroggs <matthew.w.scroggs@gmail.com>
Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
@pbrubeck pbrubeck mentioned this pull request Oct 11, 2022
Merged
pbrubeck pushed a commit to firedrakeproject/ufl that referenced this pull request Nov 1, 2022
@dham @mscroggs
@garth-wells @pbrubeck
H inf sobolev space (FEniCS#117)
6257d58 
* Add a Sobolev space spanning C infinity elements.

* Put R space in HInf

* Test Sobolev space additions.

* Use Sobolev space as the restrictions check.

* Add sobolev_space method to base finite element class (FEniCS#118)

* Add nano swp files to .gitignore

* MAke finiteelementbase into an abstract base class and add sobolev_space method

* _

* restricted element is L2

* s

* make fenicsx tests run

* branches

* _ not -

* remove branch from test config

* max

* main fenics and ffc

Co-authored-by: Matthew Scroggs <matthew.w.scroggs@gmail.com>
Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscroggs mscroggs mscroggs approved these changes

@garth-wells garth-wells garth-wells approved these changes

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Real element should be in Cinfinity
4 participants
@dham @mscroggs @wence- @garth-wells