Add sobolev_space method to base finite element class #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dham
requested changes
Aug 15, 2022
| @@ -125,6 +123,9 @@ def symmetry(self): | |||
| error("Size mismatch in symmetry algorithm.") | |||
| return sm or EmptyDict | |||
|
|
|||
| def sobolev_space(self): | |||
| return min(e.sobolev_space() for e in self._sub_elements) | |||
|
|
|||
There was a problem hiding this comment.
Is this the right thing? Suppose I have CG1 x DG0. I think this will say that the whole thing is in H1
There was a problem hiding this comment.
Yes, looks like max might be what we actually want here?
There was a problem hiding this comment.
I think that's a safe conservative option. It might disallow implicit restrictions in some cases where they would actually work, but that can be dealt with in a later pass if someone cares enough.
dham
approved these changes
Aug 15, 2022
garth-wells
added a commit
that referenced
this pull request
Aug 23, 2022
* Add a Sobolev space spanning C infinity elements. * Put R space in HInf * Test Sobolev space additions. * Use Sobolev space as the restrictions check. * Add sobolev_space method to base finite element class (#118) * Add nano swp files to .gitignore * MAke finiteelementbase into an abstract base class and add sobolev_space method * _ * restricted element is L2 * s * make fenicsx tests run * branches * _ not - * remove branch from test config * max * main fenics and ffc Co-authored-by: Matthew Scroggs <matthew.w.scroggs@gmail.com> Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
pbrubeck
pushed a commit
to firedrakeproject/ufl
that referenced
this pull request
Oct 10, 2022
* Add a Sobolev space spanning C infinity elements. * Put R space in HInf * Test Sobolev space additions. * Use Sobolev space as the restrictions check. * Add sobolev_space method to base finite element class (FEniCS#118) * Add nano swp files to .gitignore * MAke finiteelementbase into an abstract base class and add sobolev_space method * _ * restricted element is L2 * s * make fenicsx tests run * branches * _ not - * remove branch from test config * max * main fenics and ffc Co-authored-by: Matthew Scroggs <matthew.w.scroggs@gmail.com> Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
pbrubeck
pushed a commit
to firedrakeproject/ufl
that referenced
this pull request
Nov 1, 2022
* Add a Sobolev space spanning C infinity elements. * Put R space in HInf * Test Sobolev space additions. * Use Sobolev space as the restrictions check. * Add sobolev_space method to base finite element class (FEniCS#118) * Add nano swp files to .gitignore * MAke finiteelementbase into an abstract base class and add sobolev_space method * _ * restricted element is L2 * s * make fenicsx tests run * branches * _ not - * remove branch from test config * max * main fenics and ffc Co-authored-by: Matthew Scroggs <matthew.w.scroggs@gmail.com> Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sobolev_space method to base finite element class
Made base finite element class into an abc abstract class, so that elements cannot be created without methods such as sobolev_space being implemented
This builds on #117, and is currently set to merge into that branch so it can be part of that PR.