forked from vedderb/bldc
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run unit tests with github actions #1
Open
FabioBatSilva
wants to merge
6
commits into
master
Choose a base branch
from
ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoogleTest is packaged in subdirectory. ls -lah downloads/googletest-release-1.11.0/* drwxrwxr-x 2 4.0K Jun 11 2021 ci drwxrwxr-x 8 4.0K Jun 11 2021 googlemock drwxrwxr-x 9 4.0K Jun 11 2021 googletest # .... First download the zip file, then unzip to a tmp dir and finaly move googletest to tools directory
kubark42
reviewed
Apr 17, 2022
This will ignore warning in gtest since it is not compatible with some of the flags beeing enforced gtest.cc:1266:43: error: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Werror=double-promotion] 1266 | costs[l_i + 1][r_i + 1] = replace + 1.00001; | ~~~~~~~~^~~~~~~~~
Compile with -O1 to make inline functions compatible with gcc utils_math.c:582: undefined reference to `utils_truncate_number' error: ld returned 1 exit status
FabioBatSilva
force-pushed
the
ci
branch
2 times, most recently
from
April 18, 2022 03:54
17cfa1c
to
e3efb2d
Compare
Unused variable ret causes error : unittest.cpp: In member function ‘virtual void Saturate2dVector_ValsOnEdgeOfRange_Test::TestBody()’: unittest.cpp:291:9: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable] 291 | bool ret; | ^~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things going on here: