use cfg attribute instead of cfg! macro #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of places where we use the cfg! macro today, but unfortunately though convenient, that pattern does not completely isolate conditional parts of the build. This is particularly pertinent on Windows, which lacks a lot of symbols that ordinarily appear in a UNIX libc. This change has been tested on at least: * Mac OS X * Windows 10 * Ubuntu 19.10 * illumos There are no more compilation errors or warnings, and the program in test/ appears work correctly.
This was referenced Apr 11, 2020
|
Hi @FillZpp -- would you be willing to take a look at this PR? Thanks. |
|
@jclulow Sure. Sorry for getting back so late, I was too busy these days :) |
|
Hey, no worries! We are all busy. Thanks for getting back! |
FillZpp
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of places where we use the cfg! macro today, but
unfortunately though convenient, that pattern does not completely
isolate conditional parts of the build. This is particularly pertinent
on Windows, which lacks a lot of symbols that ordinarily appear in a
UNIX libc.
This change has been tested on at least:
There are no more compilation errors or warnings, and the program in
test/ appears work correctly.