Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-info v0.5.10 broken on windows #50

Closed
ry opened this issue Mar 6, 2020 · 4 comments
Closed

sys-info v0.5.10 broken on windows #50

ry opened this issue Mar 6, 2020 · 4 comments

Comments

@ry
Copy link

ry commented Mar 6, 2020

https://github.com/denoland/deno/pull/4270/checks?check_run_id=490557406

error[E0425]: cannot find function `sysconf` in crate `libc`
##[error]   --> C:\Users\runneradmin\.cargo\registry\src\git.luolix.top-1ecc6299db9ec823\sys-info-0.5.10\lib.rs:396:34
    |
396 |             let buf_size = libc::sysconf(libc::_SC_HOST_NAME_MAX) as usize;
    |                                  ^^^^^^^ not found in `libc`

error[E0425]: cannot find value `_SC_HOST_NAME_MAX` in crate `libc`
##[error]   --> C:\Users\runneradmin\.cargo\registry\src\git.luolix.top-1ecc6299db9ec823\sys-info-0.5.10\lib.rs:396:48
    |
396 |             let buf_size = libc::sysconf(libc::_SC_HOST_NAME_MAX) as usize;
    |                                                ^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `gethostname` in crate `libc`
##[error]   --> C:\Users\runneradmin\.cargo\registry\src\git.luolix.top-1ecc6299db9ec823\sys-info-0.5.10\lib.rs:398:22
    |
398 |             if libc::gethostname(buf.as_mut_ptr() as *mut libc::c_char, buf_size) < 0 {
    |                      ^^^^^^^^^^^ help: a function with a similar name exists: `getsockname`

It seems v0.5.9 was also broken #42

@meithecatte
Copy link

This is fixed already on master. @FillZpp maybe it's time for another release?

@FillZpp
Copy link
Owner

FillZpp commented Mar 26, 2020

Hi @NieDzejkob @ry, sys-info v0.6.0 has been released. Please check if it is fiexed.

@FillZpp FillZpp closed this as completed Mar 26, 2020
@ry
Copy link
Author

ry commented Mar 26, 2020

No, it is still broken on windows: https://github.com/denoland/deno/pull/4495/checks?check_run_id=536592299

I would suggest you have add windows CI.

@jclulow
Copy link
Contributor

jclulow commented Apr 11, 2020

I've taken a swing at a complete fix for this in #55, and have tested in myself in a Windows 10 VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants