Support missing node/os functionality

[cknight]

I am looking into the Node polyfill for 'os' ( #3403 ). The following Node functionality does not seem to be available in Deno:

• cpus() - to get information about the logical CPU cores. See node API.
• endianness() - the endianness of the CPU for which the Deno binary was compiled. See node API Endianness #3833
• freemem() - the amount of free system memory. See node API
• getPriority([pid]) - the scheduling priority for the process specified by pid. See node API fest(std/node): implement os.getPriority() and os.setPriority() #4202
• loadavg() - an array containing the 1, 5, and 15 minute load averages. See node API
• networkInterfaces() - Returns an object containing network interfaces that have been assigned a network address. See node API
• platform() - a string identifying the operating system platform. See node API
• release() - the operating system as a string. See node API Add missing node os.release() implementation #4065
• setPriority([pid, ]priority) - Attempts to set the scheduling priority for the process specified by pid. See node API fest(std/node): implement os.getPriority() and os.setPriority() #4202
• tmpdir() - Returns the operating system's default directory for temporary files as a string. See node API feat(std/node): add os.tmpdir() implementation #4213
• totalmem() - total amount of system memory in bytes as an integer. See node API
• hostname() - host name of the operating system as a string. See node API
• type() - the operating system name as returned by uname(3). See node API
• uptime() - the system uptime in number of seconds. See node API
• userInfo([options]) - the username, uid, gid, shell, and homedir of the current user. See node API
• Signal Constants - the following Signal constants are missing from Deno but are defined in Node: SIGIOT, SIGPOLL, SIGLOST, SIGINFO, SIGUNUSED (see node API)
• POSIX and Windows Error Constants - See node API
• dlopen Constants - See node API
• Priority Constants - See node API fest(std/node): implement os.getPriority() and os.setPriority() #4202
• libuv Constants - See node API

The 'os' polyfill cannot be fully completed until the above items are implemented in Deno.

[ecyrbe]

i'm currently working on this

[ecyrbe]

CC @ry can i use the crate systemstat to implement :

• freemem()
• totalmem()
• cpus()
• uptime()

and more...

it is under more activity than sys_info and made entirely in rust. unlike what the documentation suggests, the author added windows support for all of these.

I really don't wan't to make my own /proc/stat /proc/cpuinfo parser and windows compatibility module if someone already made one.

your call.

[ecyrbe]

Or if we are not confident enough, use a libuv binding : https://docs.rs/libuv-sys2/1.34.4/libuv_sys2/
but this would be a huge depedency that i'm not sure we want to pay such a price.

[ry]

We certainly are not adding libuv (despite it being our product) it overlaps too much with Tokio.

I will look into sys_info vs systemstat.

[ecyrbe]

@ry did you have time to investigate ?

[ry]

@ecyrbe I haven't really, but systemstat seems quite reasonable. It has CI for windows unlike sys_info (which has been broken on windows for the last two releases). If anyone felt inclined to switch us from sys-info to systemstat, that would be welcome.

I haven't checked if systemstat actually does all the things that sys-info does tho.

[vladimyr]

CC @ry can i use the crate systemstat to implement :

• freemem()
• totalmem()

Unfortunately, you won't get really far with it. It doesn't support memory info on macOS: https://github.com/myfreeweb/systemstat/blob/a7c54aa/src/platform/macos.rs#L58-L60

[joakimunge]

Looks like networkInterfaces was merged into Deno a few days ago in #13475

Should networkInterfaces here then be disregarded?

[cknight]

Looks like networkInterfaces was merged into Deno a few days ago in denoland/deno#13475

Should networkInterfaces here then be disregarded?

Updated, thanks for the reminder

[khrj]

os.version() and os.machine() are also missing now

[GJZwiers]

npm:@sentry/node fails on missing os.uptime for versions 7.12.0+:

import * as Sentry from "npm:@sentry/node@7.12.0";

Sentry.init({
  dsn: "<my-sentry-dsn>",
  tracesSampleRate: 1.0,
});

async function testEvent() {
  try {
    throw new Error("Nope.");
  } catch (e) {
    Sentry.captureException(e);
    await Sentry.flush();
  }
}

await testEvent();

Error shown in Sentry UI:

Error: Not implemented: See https://github.com/denoland/deno/issues/17850
  File "/std@0.168.0/node/_utils.ts", line 23, col 9, in notImplemented
  File "/std@0.168.0/node/os.ts", line 310, col 3, in Object.uptime
  File "/C:/Users/GJZwiers/AppData/Local/deno/npm/registry.npmjs.org/@sentry/node/7.12.0/cjs/integrations/context.js", line 169, col 47, in getDeviceContext
  File "/C:/Users/GJZwiers/AppData/Local/deno/npm/registry.npmjs.org/@sentry/node/7.12.0/cjs/integrations/context.js", line 87, col 25, in Context._getContexts
  File "/C:/Users/GJZwiers/AppData/Local/deno/npm/registry.npmjs.org/@sentry/node/7.12.0/cjs/integrations/context.js", line 51, col 66, in Context.addContext

Edit: Fixed in 1.29.2

[waldyrious]

Can someone (@crowlKats?) mark the "getPriority" and "userInfo" checkboxes in the opening comment above as completed, and link both to #19370?

Also, shouldn't this test (and possibly this one too) be uncommented? /CC @kt3k