Added partial support for node:os > userInfo function #19945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zeachco
force-pushed
the
main
branch
2 times, most recently
from
53e3dc9 to
f871aa7
Compare
most packages in node uses os.userInfo to read username, shell or homedir. this changes still causes an exception on trying to read uid and gid and supports only utf-8 option for now but that's a start.
zeachco
commented
Jul 26, 2023
| const homedir = Deno.env.get("HOME"); | ||
| const shell = Deno.env.get("SHELL") || null; | ||
|
|
||
| if (!username || !homedir) throw codes.SYSERR; |
There was a problem hiding this comment.
should I throw notImplemented(SEE_GITHUB_ISSUE); here too? node does a system error when those aren't set
zeachco
commented
Jul 26, 2023
Comment on lines
+335
to
+336
| uid: -1, | ||
| gid: -1, |
There was a problem hiding this comment.
should we warn about uid/gid in the cli?
zeachco
changed the title
|
Awesome, I wasn't sure if that or would cut in the next version hence the quick minimalistic one. Great to hear. I'll close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most packages in node uses os.userInfo to read username, shell or homedir. this changes still causes an exception on trying to read
uidandgidand supports onlyutf-8option for now but that's a start.impact
While this isn't an accurate implementation, some npm packages such as https://www.npmjs.com/package/atomically (which is used by remix and many other projects) depends on it and would make a large chunk of the npm ecosystem workable, making deno more adoptable
this is linked to #17850
This feels like a "poorman solution" but if any insights on integrating [gu]id is provided I would gladly try my best to address it.
propositions:
something like
deno run --unstable-os-user-info npm:<package>