feat(ext/net): add op_network_interfaces #12964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO this should be the same check as for |
Add an op to list the network interfaces on the system. Prep work for denoland#8137 and `os.networkInterfaces()` Node compat in std. Refs denoland/deno_std#1436.
bnoordhuis
force-pushed
the
op_network_interfaces
branch
from
fe5a91a to
60e5736
Compare
|
Done. I didn't add tests because it's not exposed as a public API yet but I'll make std/node exercise it. |
|
@bnoordhuis Have you started public API part of this work? If not, I'd like to continue the rest of the work |
|
@kt3k Only minimally so please feel free to have a go at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an op to list the network interfaces on the system.
Prep work for #8137 and
os.networkInterfaces()Node compat in std.Refs #17850.
Opening this as a WIP because I'd like feedback on what permissions to check for.