Replace sys-info crate dependency with systemstat

[ry]

sys-info is broken on Windows for 3 releases now, and doesn't have proper CI. We cannot depend on that.

This other crate https://github.com/myfreeweb/systemstat looks like a good replacement

This should be a relatively easy Rust issue for someone who wants to look around the code base.

[Nimpruda]

I'm bored because of all this corona confinement stuff (I'm French) I'll take it.

[Nimpruda]

@ry There is no way to get the hostname or the os release version with systemstat shoul I just read from /proc/... for unix and execute hostname for windows (as there is no os_release).
I'm sorry I'm a bit noob with this stuff

[ry]

@Nimpruda you can return OpError::not_implemented() for those. We can get to it later.

For the tests that will break, use ignored: true.

Thanks for looking into this!

[bsene]

Hello @Nimpruda ,
Are you still working in this issue ?

[Axighi]

@ry I'll work on it.

[Axighi]

I didn't find any usage of sys-info in the code base. What am I missing here?

[oberzan]

The sys_info seems to have fixed the issue: FillZpp/sys-info-rs#50
@ry Can you confirm that?

[kmlroot]

@oberzan #4504 (review)

[ColinHarrington]

Looks like @ry is reconsidering systemstat lacking hostname and release parsing functionality, dependency issues among others. It's not a 1:1 replacement. Should the good first issue label be removed?

[joshdover]

sys-info was upgraded successfully to 0.6.1 a few days ago (#5104) but the issue remains that they don't have a windows build in their CI.

[ktfth]

Have another way to test the changes?

[Gum-Joe]

I know it's been 28 days since the last comment, but would it be worth submitting a PR to sys-info to add windows CI? It looks like it's as simple as adding an entry to Travis build files. Or am I missing something here, as it seems it's still to be decided if systemstat or sys-info will be used, particularly given Dahl comments on #4504?

[ry]

@Gum-Joe The latest releases of sys-info are working on Windows. It would be quite nice to help them get Windows CI working. For now I'm going to close this issue since it's not a problem anymore - and IIRC systemstat had its own issues.

[Gum-Joe]

@ry Ok, thank you. I've opened FillZpp/sys-info-rs#65 to add Windows CI.