Replaced sys-info with systemstat. #4504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ry
reviewed
Mar 30, 2020
| checksum = "05aec50c70fd288702bcd93284a8444607f3292dbdf2a30de5ea5dcdbe72287b" | ||
| dependencies = [ | ||
| "memchr 1.0.2", | ||
| ] |
There was a problem hiding this comment.
I didn't realize that systemstat depends on nom, and a very old version of nom at that.
Looking through their source code they have some very ridiculous macros
https://github.com/myfreeweb/systemstat/blob/a7c54aa0d052989e93f1ef84eb1686fbbfeb92f9/src/platform/linux.rs#L62-L82
This does not give me confidence...
|
Closing as stale; we'll revisit this topic after 1.0 is released. Thanks for your work @Nimpruda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced sys-info with systemstat. systemstat doesn't implement neither a hostname nor a os_release function tho, so i had to ignore the tests.