Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement set_dynamic_callstack and call_function to Instance #272

Merged
merged 3 commits into from
Mar 29, 2023
Merged

feat: implement set_dynamic_callstack and call_function to Instance #272

merged 3 commits into from
Mar 29, 2023

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Mar 20, 2023 •
edited
Loading

Description

This is a part of #273.
This PR implements set_dynamic_callstack and call_function to Instance.

And, this PR adds todo comments to some functions will be removed after solving #273

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Mar 20, 2023
@loloicci loloicci self-assigned this Mar 20, 2023
@loloicci loloicci marked this pull request as ready for review March 20, 2023 01:50
@loloicci loloicci mentioned this pull request Mar 20, 2023
Closed
8 tasks
@loloicci loloicci force-pushed the rust-go-pointer branch 2 times, most recently from efc1bc9 to 021883c Compare March 20, 2023 02:15
@loloicci loloicci mentioned this pull request Mar 22, 2023
Closed
8 tasks
@loloicci loloicci merged commit a265000 into Finschia:dynamic_link Mar 29, 2023
@loloicci loloicci deleted the rust-go-pointer branch March 29, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da1suk8 da1suk8 da1suk8 approved these changes

@dudong2 dudong2 dudong2 approved these changes

@Kynea0b Kynea0b Awaiting requested review from Kynea0b

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @dudong2 @da1suk8