Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement "ValidateDynamicLinkInterface" to vm #99

Closed
wants to merge 12 commits into from
Closed

feat: Implement "ValidateDynamicLinkInterface" to vm #99

wants to merge 12 commits into from

Conversation

loloicci
Copy link
Contributor

Description

This PR uses Finschia/cosmwasm#272 so updated after it is merged.

This PR implements ValidateDynamicLinkInterface to VM.
This is a part of Finschia/cosmwasm#273.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this Mar 22, 2023
@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Mar 22, 2023
@loloicci loloicci mentioned this pull request Mar 22, 2023
Closed
13 tasks
@loloicci loloicci force-pushed the rust-go-pointer-validate branch 4 times, most recently from c534569 to 81aa21e Compare March 29, 2023 17:45
@loloicci loloicci marked this pull request as ready for review March 31, 2023 07:47
@loloicci loloicci mentioned this pull request Apr 4, 2023
Closed
Kynea0b
Kynea0b suggested changes Apr 11, 2023
View reviewed changes
Copy link

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also test when the argument isReadOnly=true of vm.CallCallablePoint().

@loloicci
Copy link
Contributor Author

loloicci commented Apr 11, 2023 •
edited
Loading

@kokeshiM0chi

Please also test when the argument isReadOnly=true of vm.CallCallablePoint().

I think it is not on this PR and on #97
About what part of the test do you think so?

@loloicci loloicci requested a review from Kynea0b April 11, 2023 08:36
@Kynea0b
Copy link

Kynea0b commented Apr 11, 2023

I was wrong. This test is not needed as it has nothing to do with the intent of the implementation.

This was referenced Apr 11, 2023
Closed
Merged
@loloicci
Copy link
Contributor Author

Cannot merge into dynamic_link because of #102.
All changes in this PR are included in #103.

@loloicci loloicci closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da1suk8 da1suk8 da1suk8 approved these changes

@Kynea0b Kynea0b Kynea0b approved these changes

@dudong2 dudong2 Awaiting requested review from dudong2

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @Kynea0b @da1suk8