feat: add api call_callable_point and validate_dynamic_link_interface #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix to cost gas even if call callable point fails because of permission. - build libwasmvm
…er-api and, build libwasvm
remove TestDynamicReadWritePermission because this is on CallCallabePoint and it is tested on TestCallCallablePointReadonly
|
How about removing the https://github.com/line/wasmvm/blob/dynamic_link/internal/api/lib_test.go#L969-L975 and also |
This was referenced Apr 12, 2023
da1suk8
previously approved these changes
Apr 13, 2023
|
Sorry, these lines can also be remove. FYI: a0cec05 |
da1suk8
approved these changes
Apr 13, 2023
dudong2
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds call_callable_point and validate_dynamic_link_interface to GoApi.
A part of Finschia/cosmwasm#273
This PR includes #97 and #99. They are reviewed in each PR page and were not merged because there is no proper version of cosmwasm they depend on. (#102)
Types of changes
Checklist