-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Remove grpc-web/rosetta and improve server performance #1418
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
==========================================
+ Coverage 68.66% 69.57% +0.90%
==========================================
Files 767 751 -16
Lines 63512 62259 -1253
==========================================
- Hits 43611 43316 -295
+ Misses 17234 16308 -926
+ Partials 2667 2635 -32
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please introduce the reason why we remove this in this PR's description.
f688899
Description
closes: #1416
After update:
app.toml
envoy
proxy if they want to support grpc-webcosmos/rosetta
if they want to support Coinbase Rosetta API. This command also can be added in Finschia binary itself (root.go
)At this time, I also want to refactor our server code structure based on cosmos/cosmos-sdk#15041, cosmos/cosmos-sdk#16152.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml