Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change some minor things that haven't been fixed in #549 #635

Merged
merged 8 commits into from
Aug 16, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Aug 10, 2022

Description

Motivation and context

In the #549 , we changed the difference with cosmos-sdk. But there are some minor things that haven't been fixed..

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue requested review from tnasu, 0Tech and dudong2 August 10, 2022 02:30
@zemyblue zemyblue self-assigned this Aug 10, 2022
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #635 (13ebb06) into main (5534284) will decrease coverage by 0.00%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   60.22%   60.21%   -0.01%     
==========================================
  Files         817      817              
  Lines       94996    94972      -24     
==========================================
- Hits        57207    57185      -22     
  Misses      34315    34315              
+ Partials     3474     3472       -2     
Impacted Files Coverage Δ
x/authz/codec.go 0.00% <0.00%> (ø)
x/bank/keeper/send.go 84.02% <ø> (+10.06%) ⬆️
x/genutil/client/cli/migrate.go 0.00% <0.00%> (ø)
x/auth/vesting/types/codec.go 100.00% <100.00%> (ø)
x/genutil/client/testutil/migrate.go 77.14% <100.00%> (+32.69%) ⬆️
x/params/keeper/keeper.go 76.92% <100.00%> (ø)
x/foundation/authz.go 80.00% <0.00%> (-20.00%) ⬇️
x/token/validation.go 72.72% <0.00%> (-18.19%) ⬇️
x/foundation/foundation.go 70.75% <0.00%> (-2.89%) ⬇️
x/foundation/msgs.go 36.53% <0.00%> (-1.93%) ⬇️
... and 11 more

Signed-off-by: zemyblue <zemyblue@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@zemyblue zemyblue changed the title chore: minor changes chore: change some minor things that haven't been fixed in #549 Aug 11, 2022
change changelog
@0Tech 0Tech self-requested a review August 12, 2022 05:36
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit 8679ec2 into Finschia:main Aug 16, 2022
zemyblue added a commit that referenced this pull request Sep 5, 2022
* main:
  fix: wasm module's FIXME in the snapshotter.go file (#649)
  chore(deps): Bump actions/setup-go from 3.2.1 to 3.3.0 (#650)
  chore(deps): Bump actions/cache from 3.0.7 to 3.0.8 (#648)
  fix: remove legacy codes of wasm (#640)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.14 to 0.0.16 (#643)
  chore(deps): Bump actions/cache from 3.0.6 to 3.0.7 (#642)
  chore: change some minor things that haven't been fixed in #549 (#635)
  refactor: rename x/collection events (#639)
  feat: add additional fields into x/collection events (#638)
  refactor: rename x/token events (#637)
  feat: add creator into x/token EventIssue (#636)
  chore(deps): Bump github.com/coinbase/rosetta-sdk-go (#641)
  chore: change `Keeper.space` type to be same with cosmos-sdk
  refactor: remove SetBalance and SetSupply (#629)
  refactor: revert changes in x/slashing proto (#627)
  chore(deps): Bump actions/cache from 3.0.5 to 3.0.6 (#631)
  chore(deps): Bump github.com/prometheus/client_golang (#632)
  chore(deps): Bump actions/setup-go from 2.1.4 to 3.2.1 (#624)
  feat: add Query/TokenClassTypeName (#622)
  feat: add additional information into EventXXXChanged (#621)

Signed-off-by: zemyblue <zemyblue@gmail.com>

# Conflicts:
#	CHANGELOG.md
#	client/docs/statik/statik.go
#	simapp/app.go
#	x/wasm/types/events.go
@zemyblue zemyblue deleted the minor_changes branch October 14, 2022 08:39
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants