-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change some minor things that haven't been fixed in #549 #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 60.22% 60.21% -0.01%
==========================================
Files 817 817
Lines 94996 94972 -24
==========================================
- Hits 57207 57185 -22
Misses 34315 34315
+ Partials 3474 3472 -2
|
Signed-off-by: zemyblue <zemyblue@gmail.com>
0Tech
reviewed
Aug 11, 2022
zemyblue
changed the title
chore: minor changes
chore: change some minor things that haven't been fixed in #549
Aug 11, 2022
change changelog
0Tech
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tnasu
approved these changes
Aug 15, 2022
zemyblue
added a commit
that referenced
this pull request
Sep 5, 2022
* main: fix: wasm module's FIXME in the snapshotter.go file (#649) chore(deps): Bump actions/setup-go from 3.2.1 to 3.3.0 (#650) chore(deps): Bump actions/cache from 3.0.7 to 3.0.8 (#648) fix: remove legacy codes of wasm (#640) chore(deps): Bump github.com/mattn/go-isatty from 0.0.14 to 0.0.16 (#643) chore(deps): Bump actions/cache from 3.0.6 to 3.0.7 (#642) chore: change some minor things that haven't been fixed in #549 (#635) refactor: rename x/collection events (#639) feat: add additional fields into x/collection events (#638) refactor: rename x/token events (#637) feat: add creator into x/token EventIssue (#636) chore(deps): Bump github.com/coinbase/rosetta-sdk-go (#641) chore: change `Keeper.space` type to be same with cosmos-sdk refactor: remove SetBalance and SetSupply (#629) refactor: revert changes in x/slashing proto (#627) chore(deps): Bump actions/cache from 3.0.5 to 3.0.6 (#631) chore(deps): Bump github.com/prometheus/client_golang (#632) chore(deps): Bump actions/setup-go from 2.1.4 to 3.2.1 (#624) feat: add Query/TokenClassTypeName (#622) feat: add additional information into EventXXXChanged (#621) Signed-off-by: zemyblue <zemyblue@gmail.com> # Conflicts: # CHANGELOG.md # client/docs/statik/statik.go # simapp/app.go # x/wasm/types/events.go
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lbm-sdk/
tocosmos-sdk/
#600ChangeBlockedAddrState
) in bank moduleVersionMap
ofgenutil
module to be same with other module's property nameKeeper.space
type to be same with cosmos-sdkMotivation and context
In the #549 , we changed the difference with cosmos-sdk. But there are some minor things that haven't been fixed..
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml