Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional fields into x/collection events #638

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 10, 2022

Description

This patch will introduce the new fields into x/collection events:

  • EventCreatedContract
    • creator: address which created the contract.
  • EventCreatedFTClass
    • operator: address which triggered the create.
  • EventCreatedNFTClass
    • operator: address which triggered the create.
  • EventModifiedTokenClass
    • type_name: type name of the token class (the message name of the corresponding proto).
  • EventDetached
    • previous_parent: parent token before the detach.

Motivation and context

The request from our client.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #638 (03b2130) into main (5534284) will decrease coverage by 0.00%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
- Coverage   60.22%   60.21%   -0.01%     
==========================================
  Files         817      817              
  Lines       94996    94988       -8     
==========================================
- Hits        57207    57193      -14     
- Misses      34315    34328      +13     
+ Partials     3474     3467       -7     
Impacted Files Coverage Δ
simapp/export.go 12.59% <0.00%> (ø)
x/slashing/types/signing_info.go 0.00% <0.00%> (ø)
x/collection/keeper/msg_server.go 74.57% <76.00%> (-0.29%) ⬇️
x/collection/event.go 100.00% <100.00%> (ø)
x/collection/keeper/supply.go 89.11% <100.00%> (+0.02%) ⬆️
x/slashing/client/testutil/suite.go 97.84% <100.00%> (+0.01%) ⬆️
x/slashing/keeper/hooks.go 80.00% <100.00%> (+0.51%) ⬆️
x/slashing/keeper/infractions.go 85.14% <100.00%> (+0.14%) ⬆️
x/collection/msgs.go 34.81% <0.00%> (-5.93%) ⬇️
x/wasm/keeper/keeper.go 85.74% <0.00%> (-0.36%) ⬇️
... and 7 more

@0Tech 0Tech requested review from dudong2 and zemyblue August 10, 2022 04:46
@0Tech 0Tech marked this pull request as ready for review August 10, 2022 04:46
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check swagger file.

@0Tech 0Tech merged commit 400203d into Finschia:main Aug 16, 2022
@0Tech 0Tech deleted the collection_fields branch August 16, 2022 02:23
zemyblue added a commit that referenced this pull request Sep 5, 2022
* main:
  fix: wasm module's FIXME in the snapshotter.go file (#649)
  chore(deps): Bump actions/setup-go from 3.2.1 to 3.3.0 (#650)
  chore(deps): Bump actions/cache from 3.0.7 to 3.0.8 (#648)
  fix: remove legacy codes of wasm (#640)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.14 to 0.0.16 (#643)
  chore(deps): Bump actions/cache from 3.0.6 to 3.0.7 (#642)
  chore: change some minor things that haven't been fixed in #549 (#635)
  refactor: rename x/collection events (#639)
  feat: add additional fields into x/collection events (#638)
  refactor: rename x/token events (#637)
  feat: add creator into x/token EventIssue (#636)
  chore(deps): Bump github.com/coinbase/rosetta-sdk-go (#641)
  chore: change `Keeper.space` type to be same with cosmos-sdk
  refactor: remove SetBalance and SetSupply (#629)
  refactor: revert changes in x/slashing proto (#627)
  chore(deps): Bump actions/cache from 3.0.5 to 3.0.6 (#631)
  chore(deps): Bump github.com/prometheus/client_golang (#632)
  chore(deps): Bump actions/setup-go from 2.1.4 to 3.2.1 (#624)
  feat: add Query/TokenClassTypeName (#622)
  feat: add additional information into EventXXXChanged (#621)

Signed-off-by: zemyblue <zemyblue@gmail.com>

# Conflicts:
#	CHANGELOG.md
#	client/docs/statik/statik.go
#	simapp/app.go
#	x/wasm/types/events.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants