Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Fix foundation amino codec #833

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Dec 15, 2022

Description

Same PR as cosmos/cosmos-sdk#13196, but for foundation's MsgSubmitProposal.

Motivation and context

How has this been tested?

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Dec 15, 2022
@0Tech 0Tech changed the base branch from main to release/v0.46.x December 15, 2022 10:37
@0Tech 0Tech added the C:x/foundation x/foundation module label Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.46.x@6d80375). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/v0.46.x     #833   +/-   ##
==================================================
  Coverage                   ?   61.80%           
==================================================
  Files                      ?      883           
  Lines                      ?   100392           
  Branches                   ?        0           
==================================================
  Hits                       ?    62044           
  Misses                     ?    34711           
  Partials                   ?     3637           

@0Tech 0Tech marked this pull request as ready for review December 15, 2022 11:03
@0Tech 0Tech merged commit 925755c into Finschia:release/v0.46.x Dec 19, 2022
@0Tech 0Tech deleted the codec branch December 19, 2022 09:34
zemyblue added a commit that referenced this pull request Jan 25, 2023
* Add foundation amino codec

* Update CHANGELOG.md

Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Jan 31, 2023
* main:
  chore(deps): Bump docker/build-push-action from 3 to 4 (Finschia#874)
  chore(deps): Bump github.com/spf13/viper from 1.14.0 to 1.15.0 (Finschia#867)
  chore(deps): Bump actions/cache from 3.2.3 to 3.2.4 (Finschia#873)
  fix!: Fix foundation amino codec (Finschia#833) (Finschia#862)

# Conflicts:
#	go.mod
#	go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants