fix: foundation amino codec (backport #833) #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add foundation amino codec * Update CHANGELOG.md
* main: (30 commits) chore(deps): Bump actions/cache from 3.2.2 to 3.2.3 (Finschia#860) chore(deps): Bump golang.org/x/crypto from 0.4.0 to 0.5.0 (Finschia#854) feat: Remove `x/wasm` module (Finschia#850) refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853) feat: enable querying based on mempool status (only gRPC) (Finschia#840) feat(x/foundation): remove unnecessary gov-mint feature (Finschia#848) chore(deps): Bump actions/cache from 3.2.1 to 3.2.2 (Finschia#845) chore(deps): Bump github.com/mattn/go-isatty from 0.0.16 to 0.0.17 (Finschia#847) chore(deps): Bump actions/cache from 3.2.0 to 3.2.1 (Finschia#841) fix: apply foundation audit (Finschia#834) chore(deps): Bump actions/setup-go from 3.4.0 to 3.5.0 (Finschia#831) chore(deps): Bump actions/cache from 3.0.11 to 3.2.0 (Finschia#839) ci: automate release process (Finschia#829) chore(deps): Bump github.com/prometheus/common from 0.37.0 to 0.39.0 (Finschia#832) chore(deps): Bump goreleaser/goreleaser-action from 3 to 4 (Finschia#830) chore(deps): Bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (Finschia#826) chore(deps): Bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (Finschia#822) chore(deps): Bump golang.org/x/crypto from 0.2.0 to 0.4.0 (Finschia#828) feat: Get validator pubkey considering KMS (Finschia#821) Remove support for composite (BLS) key type (Finschia#817) ... # Conflicts: # x/foundation/msgs.go # x/wasm/lbmtypes/codec.go # x/wasm/types/codec.go
zemyblue
changed the title
tkxkd0159
reviewed
Jan 17, 2023
Comment on lines
71
to
72
| // Register all Amino interfaces and concrete types on the authz and gov Amino codec so that this can later be | ||
| // used to properly serialize MsgGrant, MsgExec and MsgSubmitProposal instances |
There was a problem hiding this comment.
nit: need to add comments about foundation codec (including other codec.gos)
0Tech
approved these changes
Jan 19, 2023
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Jan 31, 2023
* main: chore(deps): Bump docker/build-push-action from 3 to 4 (Finschia#874) chore(deps): Bump github.com/spf13/viper from 1.14.0 to 1.15.0 (Finschia#867) chore(deps): Bump actions/cache from 3.2.3 to 3.2.4 (Finschia#873) fix!: Fix foundation amino codec (Finschia#833) (Finschia#862) # Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #833 of
release/v0.46.xbranchMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml