Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify error case #882

Merged
merged 1 commit into from
Feb 6, 2023
Merged

chore: modify error case #882

merged 1 commit into from
Feb 6, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Feb 6, 2023

Description

closes: #XXXX

ref. #876 (comment)

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #882 (85cf38b) into main (611b286) will decrease coverage by 0.02%.
The diff coverage is 96.03%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   62.37%   62.36%   -0.02%     
==========================================
  Files         653      653              
  Lines       79976    79961      -15     
==========================================
- Hits        49885    49867      -18     
- Misses      27399    27401       +2     
- Partials     2692     2693       +1     
Impacted Files Coverage Δ
x/collection/keeper/send.go 91.75% <ø> (-0.33%) ⬇️
x/token/keeper/send.go 89.18% <ø> (-0.94%) ⬇️
x/collection/codec.go 44.59% <50.00%> (ø)
x/token/codec.go 57.89% <57.14%> (ø)
x/bankplus/keeper/keeper.go 92.06% <80.00%> (-4.17%) ⬇️
x/collection/msgs.go 96.72% <97.64%> (ø)
simapp/app.go 82.30% <100.00%> (ø)
x/collection/client/testutil/query.go 100.00% <100.00%> (ø)
x/collection/client/testutil/suite.go 99.60% <100.00%> (ø)
x/collection/client/testutil/tx.go 100.00% <100.00%> (ø)
... and 21 more

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add more description?

@tkxkd0159
Copy link
Member Author

Could you add more description?

Okay. I added associated link

@tkxkd0159 tkxkd0159 merged commit 471a4d7 into Finschia:main Feb 6, 2023
@tkxkd0159 tkxkd0159 deleted the chore-test branch February 6, 2023 08:29
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants