-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: apply changes to replace Ostracon proto message with Tendermint #869
Conversation
- (replace a some same proto message to Tendermint )
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
+ Coverage 62.37% 62.45% +0.07%
==========================================
Files 653 653
Lines 79976 79873 -103
==========================================
- Hits 49885 49884 -1
+ Misses 27399 27298 -101
+ Partials 2692 2691 -1
|
* main: chore(deps): Bump docker/build-push-action from 3 to 4 (Finschia#874) chore(deps): Bump github.com/spf13/viper from 1.14.0 to 1.15.0 (Finschia#867) chore(deps): Bump actions/cache from 3.2.3 to 3.2.4 (Finschia#873) fix!: Fix foundation amino codec (Finschia#833) (Finschia#862) # Conflicts: # go.mod # go.sum
You may increase the upgrade height. |
You may revert my previous suggestion. It seems the logic relevant to log parsing has been changed in this PR. To reproduce the CI failure, you must wipe out Refer: 0Tech#4. |
I want to ignore codecov error of ci Because this PR almost change the imported path and Ostracon's proto path, so many files are changed but some files do not have unittest or low coverage. I cannot add unittest of these all files. |
* main: feat!: add MultiSend deactivation (Finschia#876) chore(deps): Bump github.com/gogo/protobuf in /ics23/go (Finschia#816) fix: do not create account on x/token,collection (Finschia#866) fix!: update x/collection,token proto (Finschia#863) # Conflicts: # CHANGELOG.md
Ci Unittest error is occurred by #876 (comment). |
* main: modify error case (Finschia#882)
Description
apply changes to replace Ostracon proto message with Tendermint (Finschia/ostracon#546)
Breaking changes
This changes has breaking change.
Motivation and context
The reason is same with Finschia/ostracon#546 change.
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml