Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: apply the changes of lbm-sdk and ostracon proto #5

Merged
merged 7 commits into from
Feb 10, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 9, 2023

Description

Main changes

  • Remove Ostracon protobuf struct and message which same with Tendermint
  • VRF Proof move from block.header to Entropy in Block structure

warning

  • RequestBeginBlock, RequestBeginRecheckTx and RequestEndRecheckTx of abci proto are Ostracon's proto, so these should be use ostracon import(github.com/line/ostracon/abci/types)

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

 - base lbm-sdk commit: b8864730859710d92a83f9f91289d4c6aef658cd
@zemyblue zemyblue marked this pull request as draft February 9, 2023 16:30
@zemyblue zemyblue self-assigned this Feb 10, 2023
@zemyblue zemyblue marked this pull request as ready for review February 10, 2023 00:13
testing/chain.go Outdated Show resolved Hide resolved
testing/chain.go Outdated Show resolved Hide resolved
@0Tech 0Tech self-requested a review February 10, 2023 02:00
Copy link

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
There seems to be no difference with the tendermint light client.

@zemyblue
Copy link
Member Author

LGTM
There seems to be no difference with the tendermint light client.

Yes, that's right. But we don't use right now. Because some structure is same struct with Tendermint, but we use Ostracon's structure. So the compiler recognize as different object.

So I think it's better that we need to replace to use Tendermint's structure in Ostracon if same.

@zemyblue zemyblue merged commit d855e1d into Finschia:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants