-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: apply the changes of lbm-sdk and ostracon proto #5
Conversation
….com/cosmos/ibc-go/v3`
- base lbm-sdk commit: b8864730859710d92a83f9f91289d4c6aef658cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There seems to be no difference with the tendermint light client.
Yes, that's right. But we don't use right now. Because some structure is same struct with Tendermint, but we use Ostracon's structure. So the compiler recognize as different object. So I think it's better that we need to replace to use Tendermint's structure in Ostracon if same. |
Description
Main changes
warning
RequestBeginBlock
,RequestBeginRecheckTx
andRequestEndRecheckTx
of abci proto are Ostracon's proto, so these should be use ostracon import(github.com/line/ostracon/abci/types
)Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml