feat!: replace a some same proto message to Tendermint #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1eeb90f)
* abci -> ocabci * tmabci -> abci
|
|
…`AuthSigMessage` of `ostracon/p2p/conn`
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 66.10% 66.15% +0.05%
==========================================
Files 278 278
Lines 36981 36943 -38
==========================================
- Hits 24445 24439 -6
+ Misses 10778 10749 -29
+ Partials 1758 1755 -3
|
- ValidatorSet, Validator, SimpleValidator
Kynea0b
added
the
C: enhancement
…nt proto. - abci.RequestInitChain - abci.ResponseEndBlock - abci.LastCommitInfo - abci.Validator - abci.ValidatorUpdate - abci.VoterInfo - state.ValidatorsInfo
…rmint proto. - privval.PubKeyResponse - types.Commit
- abci.Evidence
tnasu
reviewed
Jan 30, 2023
Apply feed-back Co-authored-by: Toshimasa Nasu <toshimasa_nasu@hotmail.com>
chore: apply feed-back Co-authored-by: Toshimasa Nasu <toshimasa_nasu@hotmail.com>
|
OK, If then, @tnasu , is it ok to change all Other than the ones you pointed out, they are included in the list below.
Next files has just ostracon's
|
|
I've checked the below with And I've also the below with |
tnasu
reviewed
Jan 31, 2023
tnasu
approved these changes
Jan 31, 2023
torao
approved these changes
Feb 1, 2023
4 tasks
ulbqb
approved these changes
Feb 1, 2023
zemyblue
added a commit
to Finschia/finschia-sdk
that referenced
this pull request
Feb 6, 2023
#869) * feat!: apply the changes of Finschia/ostracon#546 - (replace a some same proto message to Tendermint ) * chore: fix lint error * chore: add changelog * chore: add more unittest * chore: increase upgrade_height of cosmovisor test. (5->20) * fix: test-cosmovisor error * chore: apply feedback of review. * docs: update proto format and related document.
tnasu
added a commit
to tnasu/ostracon
that referenced
this pull request
Mar 2, 2023
tnasu
added a commit
to tnasu/ostracon
that referenced
this pull request
Mar 2, 2023
tnasu
added a commit
to tnasu/ostracon
that referenced
this pull request
Mar 2, 2023
tnasu
added a commit
to tnasu/ostracon
that referenced
this pull request
Mar 2, 2023
Merged
tnasu
added a commit
that referenced
this pull request
Mar 7, 2023
* Switch to default/ocabci: #546 (comment) * Switch to bcproto/ocbcproto: #546 (comment) * Switch to bcproto/ocbcproto: #546 (comment) * Switch to types/octypes: #546 (comment) * Revert to privvalproto * Format import * Add test for codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR remove a same proto messages with Tendemrint in proto file and change to import tendermint lib.
Background
Like #543 , Ostracon should be as compatible as possible with IBC and Cosmos-SDK. And among the proto messages, the same things as Tendermint are re-defined and used as Ostracon proto. Due to these parts, it is very difficult to be compatible with IBC and Cosmos-SDK. Therefore, it is necessary to use Tendermint proto message as identifical as possible.
Detail Changes
Changed
This change is based on Tendermint v0.34.19.
The following proto messages are removed and change to reference Tendermint proto message.
abci/types.protoRequestEcho,RequestFlush,RequestInfo,RequestSetOption,RequestInitChain,RequestQuery,RequestCheckTx,RequestDeliverTx,RequestEndBlock,RequestCommit,RequestListSnapshots,RequestOfferSnapshot,RequestLoadSnapshotChunk,RequestApplySnapshotChunkResponseException,ResponseEcho,ResponseFlush,ResponseInfo,ResponseSetOption,ResponseInitChain,ResponseQuery,ResponseBeginBlock,ResponseDeliverTx,ResponseEndBlock,ResponseCommit,ResponseListSnapshots,ResponseOfferSnapshot,ResponseLoadSnapshotChunk,ResponseApplySnapshotChunkenum CheckTxType,enum ResultConsensusParams,BlockParams,LastCommitInfo,Event,EventAttribute,TxResultValidator,ValidatorUpdate,VoteInfo,EvidenceType,Evidence,Snapshotblockchain/types.protoBlockRequest,NoBlockResponse,StatusRequest,StatusResponseprivval/types.protoenum ErrorsRemoteSignerError,PubKeyRequest,PubKeyResponse,SignVoteRequest,SignedVoteResponse,SignProposalRequest,SignedProposalResponse,PingRequest,PingResponsestate/types.protoValidatorsInfo,ConsensusParamsInfo,Versiontypes/types.protoenum BlockIDFlag,enum SignedMsgType,PartSetHeader,Part,BlockID,Data,Vote,Commit,CommitSig,Proposal,TxProofRemoved
The following proto file is removed. Because all proto messages is same with Tendermint.
consensus/types.protoconsensus/wal.protocrypto/keys.protocrypto/proof.protolibs/bits/types.protomempool/types.protop2p/conn.protop2p/pex.protop2p/types.protostatesync/types.protostore/types.prototypes/canonical.prototypes/events.prototypes/params.prototypes/validator.protoversion/types.protoResult
The following custom proto file remains. And the related file import path is changed.
abci/types.protoRequestBeginBlockandResponseCheckTxare remained to support custom block header. AndRequestBeginRecheckTxandRequestEndRecheckTxrequest are added.blockchain/types.protoprivval/types.protorpc/grpc/types.protoResponseBroadcastTxis changed to support custom block header.state/types.protoStatefor savinglast_proof_hashtypes/block.prototypes/evidence.protoLightClientAttackEvidenceis addedtypes/types.protoSignedHeader,LightBlockandBlockMetafor supporting custom block header.