Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up x/foundation api #933

Merged
merged 6 commits into from
Mar 21, 2023
Merged

chore: clean up x/foundation api #933

merged 6 commits into from
Mar 21, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Mar 16, 2023

Description

This patch would hide unnecessary apis of x/foundation.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the C:x/foundation x/foundation module label Mar 16, 2023
@0Tech 0Tech self-assigned this Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #933 (2629fcc) into main (c025e91) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   62.36%   62.36%   -0.01%     
==========================================
  Files         655      655              
  Lines       79763    79763              
==========================================
- Hits        49745    49744       -1     
- Misses      27334    27335       +1     
  Partials     2684     2684              
Impacted Files Coverage Δ
x/foundation/keeper/internal/abci.go 75.00% <ø> (ø)
x/foundation/keeper/internal/censorship.go 82.16% <ø> (ø)
x/foundation/keeper/internal/exec.go 93.42% <ø> (ø)
x/foundation/keeper/internal/genesis.go 97.22% <ø> (ø)
x/foundation/keeper/internal/grpc_query.go 3.90% <ø> (ø)
x/foundation/keeper/internal/invariants.go 100.00% <ø> (ø)
x/foundation/keeper/internal/keeper.go 89.47% <ø> (ø)
x/foundation/keeper/internal/keys.go 98.11% <ø> (ø)
x/foundation/keeper/internal/member.go 93.33% <ø> (ø)
x/foundation/keeper/internal/migrations.go 0.00% <ø> (ø)
... and 7 more

... and 1 file with indirect coverage changes

@0Tech 0Tech marked this pull request as ready for review March 16, 2023 09:14
This reverts commit 8dd124d.
@0Tech 0Tech merged commit aabe516 into Finschia:main Mar 21, 2023
@0Tech 0Tech deleted the foundation-api branch March 21, 2023 05:59
zemyblue pushed a commit to zemyblue/finschia-sdk that referenced this pull request Mar 22, 2023
* Hide unnecessary apis

* Use x/foundation mocks

* Lint

* Update CHANGELOG.md

* Remove interface

* Revert "Remove interface"

This reverts commit 8dd124d.

(cherry picked from commit aabe516)
zemyblue added a commit that referenced this pull request Mar 22, 2023
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request May 2, 2023
* main: (38 commits)
  chore(deps): Bump github.com/coinbase/rosetta-sdk-go from 0.8.2 to 0.8.3 (Finschia#976)
  chore(deps): Bump github.com/prometheus/client_golang from 1.14.0 to 1.15.0 (Finschia#967)
  chore(deps): Bump golang.org/x/crypto from 0.0.0-20200622213623-75b288015ac9 to 0.1.0 in /ics23/go (Finschia#972)
  chore(deps): Bump gaurav-nelson/github-action-markdown-link-check from 1.0.14 to 1.0.15 (Finschia#975)
  chore(deps): Bump DoozyX/clang-format-lint-action from 0.15 to 0.16 (Finschia#989)
  chore(deps): Bump actions/cache from 3.2.4 to 3.3.1 (Finschia#974)
  chore(deps): Bump golang.org/x/crypto from 0.7.0 to 0.8.0 (Finschia#958)
  chore(deps): Bump github.com/spf13/cobra from 1.6.1 to 1.7.0 (Finschia#949)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.17 to 0.0.18 (Finschia#941)
  chore(deps): Bump codecov/codecov-action from 3.1.1 to 3.1.3 (Finschia#985)
  chore(deps): Bump github.com/Finschia/ostracon from 1.0.10-0.20230417071658-1c9c22cfe90d to 1.1.0 (Finschia#987)
  chore: update url path in changelog
  chore(deps): Bump google.golang.org/protobuf from 1.28.1 to 1.30.0 (Finschia#935)
  chore(deps): Bump actions/cache from 3.2.6 to 3.3.1 (Finschia#928)
  chore: add progress log into x/collection import-genesis (Finschia#938)
  chore(deps): Bump github.com/line/ostracon from 1.0.9-0.20230209043112-5aca894db3a6 to 1.0.9 (Finschia#939)
  chore: clean up x/foundation api (Finschia#933)
  chore(deps): Bump actions/setup-go from 3.5.0 to 4.0.0 (Finschia#931)
  chore(deps): Bump github.com/golang/protobuf from 1.5.2 to 1.5.3 (Finschia#926)
  chore(deps): Bump golang.org/x/crypto from 0.0.0-20200622213623-75b288015ac9 to 0.1.0 in /ics23/go (Finschia#916)
  ...

# Conflicts:
#	CHANGELOG.md
#	go.mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants