Backport main changes (#900, #911, #912, #922, #923, #934, #939, #933, #934, #938) #937

zemyblue · 2023-03-17T09:16:45Z

Description

backporting list

fix: add missing Command(collection module's TxCmdModify) (fix: add missing Command(collection module's TxCmdModify) #911)
feat: add "uri" for MsgModify and deprecate the old ones (feat: add "uri" for MsgModify and deprecate the old ones #900)
deprecate block mode in proto (deprecate block mode in proto #923)
feat: introduce censorship into x/foundation (feat: introduce censorship into x/foundation #912)
fix: propagate events in x/foundation through sdk.Results (fix: propagate events in x/foundation through sdk.Results #922)
docs: update permlinks in x/foundation documents (docs: update permlinks in x/foundation documents #934)
bump(deps): bump up Ostracon to v1.0.9 (chore(deps): Bump github.com/line/ostracon from 1.0.9-0.20230209043112-5aca894db3a6 to 1.0.9 #939)
chore: clean up x/foundation api (chore: clean up x/foundation api #933)
docs: update permlinks in x/foundation documents (docs: update permlinks in x/foundation documents #934)
chore: add progress log into x/collection import-genesis (chore: add progress log into x/collection import-genesis #938)

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

* Fix: typos Fix: typos * Fix: typo Fix: typo * Fix: typo Fix: typo * go fmt --------- Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>

* Add uri to x/token * Add tests * Add uri to x/collection * Add tests * Update CHANGELOG.md * Update CHANGELOG.md * Emit both old and new change * Add tests * Remove xxx_uri from events * Revert irrelevant changes * Lint (cherry picked from commit 81fec6d)

* feat: deprecate block mode in proto * add changelog (cherry picked from commit b626dec)

* Add censorship into proto * Implement censorship * Add FoundationExecProposal to proto * Implement FoundationExecProposal * Update documentation * Update CHANGELOG.md * Rename files * Lint * Add amino test on MsgUpdateCensorship * Add pagination on cli * Update x/foundation/README.md * Update proposal cli description * Chore * Apply feedbacks (cherry picked from commit d9428ec)

* Propagate events in x/foundation through sdk.Results * Update CHANGELOG.md (cherry picked from commit c025e91)

* Update links in documentation * Update CHANGELOG.md (cherry picked from commit 7623acc)

codecov · 2023-03-17T09:48:56Z

Codecov Report

Merging #937 (a6ca9e7) into rc/v0.47.0-alpha1 (11966d1) will increase coverage by 0.05%.
The diff coverage is 78.00%.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           rc/v0.47.0-alpha1     #937      +/-   ##
=====================================================
+ Coverage              62.33%   62.38%   +0.05%     
=====================================================
  Files                    653      655       +2     
  Lines                  79467    79818     +351     
=====================================================
+ Hits                   49536    49795     +259     
- Misses                 27252    27338      +86     
- Partials                2679     2685       +6

Impacted Files	Coverage Δ
client/context.go	`53.93% <0.00%> (ø)`
crypto/keys/secp256k1/internal/secp256k1/curve.go	`42.85% <ø> (ø)`
simapp/test_helpers.go	`9.96% <ø> (+0.10%)`	⬆️
store/types/listening.go	`68.42% <ø> (ø)`
x/foundation/client/testutil/grpc.go	`91.89% <ø> (-0.61%)`	⬇️
x/foundation/keeper/internal/abci.go	`75.00% <ø> (ø)`
x/foundation/keeper/internal/grpc_query.go	`3.90% <0.00%> (ø)`
x/foundation/keeper/internal/invariants.go	`100.00% <ø> (ø)`
x/foundation/keeper/internal/keeper.go	`89.47% <ø> (ø)`
x/foundation/keeper/internal/migrations.go	`0.00% <ø> (ø)`
... and 32 more

... and 1 file with indirect coverage changes

0Tech · 2023-03-21T07:51:55Z

Can you please add the latest PRs (#933, #934, #938)?

Also #939, for ostracon.

* Hide unnecessary apis * Use x/foundation mocks * Lint * Update CHANGELOG.md * Remove interface * Revert "Remove interface" This reverts commit 8dd124d. (cherry picked from commit aabe516)

* Update links in documentation * Update CHANGELOG.md (cherry picked from commit 7623acc) (cherry picked from commit b748d70)

* Add log into x/collection import * Update CHANGELOG.md (cherry picked from commit 7e85625)

tkxkd0159 and others added 8 commits March 17, 2023 17:48

build: update release pipeline to match non-wasm env (Finschia#901)

924cf98

chore: typos (Finschia#857)

f3ce309

* Fix: typos Fix: typos * Fix: typo Fix: typo * Fix: typo Fix: typo * go fmt --------- Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>

fix: add missing Command(collection module's TxCmdModify) (Finschia#911)

220083d

deprecate block mode in proto (Finschia#923)

8fbfb7c

* feat: deprecate block mode in proto * add changelog (cherry picked from commit b626dec)

fix: propagate events in x/foundation through sdk.Results (Finschia#922)

6a35014

* Propagate events in x/foundation through sdk.Results * Update CHANGELOG.md (cherry picked from commit c025e91)

docs: update permlinks in x/foundation documents (Finschia#934)

b748d70

* Update links in documentation * Update CHANGELOG.md (cherry picked from commit 7623acc)

zemyblue changed the title ~~Backport main changes~~ Backport main changes (#900, #911, #912, #922, #923, #934) Mar 17, 2023

zemyblue self-assigned this Mar 17, 2023

zemyblue requested review from 0Tech, jaeseung-bae, tkxkd0159, dudong2 and loin3 March 17, 2023 09:54

dudong2 previously approved these changes Mar 21, 2023

View reviewed changes

feat: bump up ostracon version to v1.0.9 (backport Finschia#939)

a063fd0

zemyblue dismissed dudong2’s stale review via a063fd0 March 21, 2023 06:37

zemyblue changed the title ~~Backport main changes (#900, #911, #912, #922, #923, #934)~~ Backport main changes (#900, #911, #912, #922, #923, #934, #939) Mar 21, 2023

zemyblue requested a review from dudong2 March 21, 2023 07:33

loin3 previously approved these changes Mar 21, 2023

View reviewed changes

0Tech added 3 commits March 22, 2023 15:35

chore: clean up x/foundation api (Finschia#933)

54def7b

* Hide unnecessary apis * Use x/foundation mocks * Lint * Update CHANGELOG.md * Remove interface * Revert "Remove interface" This reverts commit 8dd124d. (cherry picked from commit aabe516)

docs: update permlinks in x/foundation documents (Finschia#934)

776d4de

* Update links in documentation * Update CHANGELOG.md (cherry picked from commit 7623acc) (cherry picked from commit b748d70)

chore: add progress log into x/collection import-genesis (Finschia#938)

a6ca9e7

* Add log into x/collection import * Update CHANGELOG.md (cherry picked from commit 7e85625)

zemyblue dismissed loin3’s stale review via a6ca9e7 March 22, 2023 06:39

0Tech approved these changes Mar 22, 2023

View reviewed changes

zemyblue changed the title ~~Backport main changes (#900, #911, #912, #922, #923, #934, #939)~~ Backport main changes (#900, #911, #912, #922, #923, #934, #939, #933, #934, #938) Mar 22, 2023

zemyblue requested a review from loin3 March 22, 2023 07:04

tkxkd0159 approved these changes Mar 22, 2023

View reviewed changes

zemyblue merged commit 8bb999d into Finschia:rc/v0.47.0-alpha1 Mar 22, 2023

0Tech mentioned this pull request Mar 22, 2023

Bump github.com/line/lbm-sdk from v0.47.0-alpha1.0.20230214070148-11966d123415 to v0.47.0-rc1 Finschia/finschia#154

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport main changes (#900, #911, #912, #922, #923, #934, #939, #933, #934, #938) #937

Backport main changes (#900, #911, #912, #922, #923, #934, #939, #933, #934, #938) #937

zemyblue commented Mar 17, 2023 •

edited

Loading

codecov bot commented Mar 17, 2023 •

edited

Loading

0Tech commented Mar 21, 2023 •

edited

Loading

Backport main changes (#900, #911, #912, #922, #923, #934, #939, #933, #934, #938) #937

Backport main changes (#900, #911, #912, #922, #923, #934, #939, #933, #934, #938) #937

Conversation

zemyblue commented Mar 17, 2023 • edited Loading

Description

backporting list

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov bot commented Mar 17, 2023 • edited Loading

Codecov Report

0Tech commented Mar 21, 2023 • edited Loading

zemyblue commented Mar 17, 2023 •

edited

Loading

codecov bot commented Mar 17, 2023 •

edited

Loading

0Tech commented Mar 21, 2023 •

edited

Loading