Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unifying compilation and docker image build #227

Closed
zemyblue opened this issue Jun 26, 2023 · 0 comments · Fixed by #237
Closed

Unifying compilation and docker image build #227

zemyblue opened this issue Jun 26, 2023 · 0 comments · Fixed by #237
Assignees
@zemyblue
Milestone
v2.0.0

Comments

@zemyblue
Copy link
Member 

          We get similar binaries by several logics, by Makefile or by Dockerfile. This pr adds the way even more. We should consider tidy up the logics. We can reuse some logics in the other logics.

Also, we should concentrate on the main targets. The others just increases our burden on maintenance & QA.

Originally posted by @0Tech in #221 (review)
@zemyblue zemyblue added this to the v2.0.0 milestone Jun 26, 2023
@zemyblue zemyblue self-assigned this Jun 26, 2023
@zemyblue zemyblue mentioned this issue Jul 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zemyblue zemyblue

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

build: rearrange Dockerfile and Makefile commands zemyblue/finschia
1 participant
@zemyblue