feat: compile static binary as release assets and docker image #221

zemyblue · 2023-06-19T11:41:06Z

Description

closes: #71 , #203

Changes

add multi-platform docker image building, and push to docker hub.
fix the bug that the fnsad version in docker image was not displayed.
add the static fnsad binary compile function (just support linux/amd64 and linux/arm64)
change base docker image

Motivation and context

The release assets cannot execute without install dynamic library(libwasmvm). So it is very uncomfortable.

How has this been tested?

Screenshots (if appropriate):

The sample release assets results.

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.

Signed-off-by: zemyblue <zemyblue@gmail.com>

.github/workflows/docker.yml

README.md

Signed-off-by: zemyblue <zemyblue@gmail.com>

0Tech

We get similar binaries by several logics, by Makefile or by Dockerfile. This pr adds the way even more. We should consider tidy up the logics. We can reuse some logics in the other logics.
Also, we should concentrate on the main targets. The others just increases our burden on maintenance & QA.

.github/workflows/docker.yml

zemyblue · 2023-06-22T09:20:14Z

We get similar binaries by several logics, by Makefile or by Dockerfile. This pr adds the way even more. We should consider tidy up the logics. We can reuse some logics in the other logics.
Also, we should concentrate on the main targets. The others just increases our burden on maintenance & QA.

Yes, there are meny build option and it is a little complex. I also think It need to arrange it. I'll add as a issue it. And I'll try to fix it as another pr.

Signed-off-by: zemyblue <zemyblue@gmail.com>

…hia#221) * build: modify docker image base and binary using static library. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: change the description in readme Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: localnet-docker-build unittest Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change the github action ci for pushing Docker images Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change release build for using static binary assets. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: parse tag in github action of docker.yml Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change docker build and push trigger Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: remove condition if `pull_request` or not. Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: typo Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: remove debian11 and nonroot base docker image Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit 225b581)

…res (#221, #223) (#225) * feat: add integrated swagger for finschia (#223) * feat: add integrated swagger for finschia. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: add a ci to check generated code. Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: add a ci to check generated code up-to-date Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: ci error Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit b98ef07008b1a1e93882447e67286a0a2ae6339f) --------- Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit d649d83) * feat: compile static binary as release assets and docker image (#221) * build: modify docker image base and binary using static library. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: change the description in readme Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: localnet-docker-build unittest Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change the github action ci for pushing Docker images Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change release build for using static binary assets. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: parse tag in github action of docker.yml Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change docker build and push trigger Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: remove condition if `pull_request` or not. Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: typo Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: remove debian11 and nonroot base docker image Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit 225b581) * fix: build option error Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: build option error in docker Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: build option error in docker Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com>

zemyblue added 5 commits June 19, 2023 20:15

build: modify docker image base and binary using static library.

ebc3e42

Signed-off-by: zemyblue <zemyblue@gmail.com>

chore: change the description in readme

7b6f95c

Signed-off-by: zemyblue <zemyblue@gmail.com>

fix: localnet-docker-build unittest

431d55b

Signed-off-by: zemyblue <zemyblue@gmail.com>

ci: change the github action ci for pushing Docker images

0977af2

Signed-off-by: zemyblue <zemyblue@gmail.com>

ci: change release build for using static binary assets.

906cb90

Signed-off-by: zemyblue <zemyblue@gmail.com>

zemyblue added bug Something isn't working enhancement New feature or request labels Jun 19, 2023

zemyblue self-assigned this Jun 19, 2023

zemyblue requested review from torao, tnasu, 0Tech, dudong2, shiki-tak, loin3 and jaeseung-bae June 19, 2023 11:41

zemyblue added 3 commits June 19, 2023 21:01

chore: update changelog

13a09a3

Signed-off-by: zemyblue <zemyblue@gmail.com>

fix: parse tag in github action of docker.yml

b9a297a

Signed-off-by: zemyblue <zemyblue@gmail.com>

ci: change docker build and push trigger

d5c0c42

Signed-off-by: zemyblue <zemyblue@gmail.com>

zemyblue linked an issue Jun 19, 2023 that may be closed by this pull request

Can't check the version in docker image of finschianode #203

Closed

4 tasks

zemyblue requested a review from tkxkd0159 June 19, 2023 12:40

jaeseung-bae reviewed Jun 20, 2023

View reviewed changes

.github/workflows/docker.yml Outdated Show resolved Hide resolved

.github/workflows/docker.yml Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

zemyblue added 2 commits June 20, 2023 20:05

ci: remove condition if pull_request or not.

de4cfaf

Signed-off-by: zemyblue <zemyblue@gmail.com>

fix: typo

a55e8cc

Signed-off-by: zemyblue <zemyblue@gmail.com>

zemyblue requested a review from jaeseung-bae June 20, 2023 11:07

jaeseung-bae previously approved these changes Jun 21, 2023

View reviewed changes

0Tech reviewed Jun 22, 2023

View reviewed changes

.github/workflows/docker.yml Show resolved Hide resolved

0Tech self-requested a review June 22, 2023 09:44

chore: remove debian11 and nonroot base docker image

d551054

Signed-off-by: zemyblue <zemyblue@gmail.com>

zemyblue dismissed jaeseung-bae’s stale review via d551054 June 22, 2023 11:58

zemyblue requested a review from jaeseung-bae June 22, 2023 12:15

zemyblue added this to the v2.0.0 milestone Jun 22, 2023

0Tech previously approved these changes Jun 23, 2023

View reviewed changes

jaeseung-bae previously approved these changes Jun 23, 2023

View reviewed changes

Merge branch 'main' into feat/change_to_static_binary

39d6edc

zemyblue dismissed stale reviews from jaeseung-bae and 0Tech via 39d6edc June 23, 2023 05:29

zemyblue requested review from 0Tech and jaeseung-bae June 23, 2023 05:32

jaeseung-bae approved these changes Jun 23, 2023

View reviewed changes

0Tech approved these changes Jun 23, 2023

View reviewed changes

zemyblue merged commit 225b581 into Finschia:main Jun 23, 2023

zemyblue deleted the feat/change_to_static_binary branch June 23, 2023 06:06

This was referenced Jun 23, 2023

feat: backport integrated swagger and static binary compilation features (#221, #223) #225

Merged

Unifying compilation and docker image build #227

Closed

0Tech mentioned this pull request Jul 13, 2023

build: update release bundle structure for cosmovisor #211

Closed

4 tasks

This was referenced Jul 13, 2023

chore: fix Makefile for format and execute make format #230

Merged

fix: compile error when the build_tags is multiple. #236

Merged

build: rearrange Dockerfile and Makefile commands #237

Merged

zemyblue mentioned this pull request Oct 19, 2023

Release finschia v2.0.0 #288

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: compile static binary as release assets and docker image #221

feat: compile static binary as release assets and docker image #221

zemyblue commented Jun 19, 2023 •

edited

Loading

0Tech left a comment

zemyblue commented Jun 22, 2023

feat: compile static binary as release assets and docker image #221

feat: compile static binary as release assets and docker image #221

Conversation

zemyblue commented Jun 19, 2023 • edited Loading

Description

Changes

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

0Tech left a comment

Choose a reason for hiding this comment

zemyblue commented Jun 22, 2023

zemyblue commented Jun 19, 2023 •

edited

Loading