feat: add integrated swagger for finschia #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage 43.97% 43.97%
=======================================
Files 8 8
Lines 1087 1087
=======================================
Hits 478 478
Misses 591 591
Partials 18 18
|
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit b98ef07008b1a1e93882447e67286a0a2ae6339f)
zemyblue
requested review from
0Tech,
dudong2,
tkxkd0159,
loin3 and
jaeseung-bae
loin3
reviewed
Jun 23, 2023
dudong2
approved these changes
Jun 23, 2023
loin3
approved these changes
Jun 23, 2023
zemyblue
added a commit
to zemyblue/finschia
that referenced
this pull request
Jun 23, 2023
* feat: add integrated swagger for finschia. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: add a ci to check generated code. Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: add a ci to check generated code up-to-date Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: ci error Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit b98ef07008b1a1e93882447e67286a0a2ae6339f) --------- Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit d649d83)
4 tasks
zemyblue
added a commit
that referenced
this pull request
Jun 26, 2023
…res (#221, #223) (#225) * feat: add integrated swagger for finschia (#223) * feat: add integrated swagger for finschia. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: add a ci to check generated code. Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: add a ci to check generated code up-to-date Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: ci error Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit b98ef07008b1a1e93882447e67286a0a2ae6339f) --------- Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit d649d83) * feat: compile static binary as release assets and docker image (#221) * build: modify docker image base and binary using static library. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: change the description in readme Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: localnet-docker-build unittest Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change the github action ci for pushing Docker images Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change release build for using static binary assets. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: parse tag in github action of docker.yml Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change docker build and push trigger Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: remove condition if `pull_request` or not. Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: typo Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: remove debian11 and nonroot base docker image Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit 225b581) * fix: build option error Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: build option error in docker Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: build option error in docker Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #214
Add integrated swagger host.
The query or service proto of finschia-sdk and wasmd and ibc-go are integrated.
And I add a check ci in order to konw if the protobuf of module is changed. (
check-generated.yml)This swagger can be updated by
make proto-swagger-gen.Motivation and context
The swagger interface of current finschia node display only fisnchia-sdk APIs, so we cannot use wasmd's api and ibc-go's api. It is very uncomfortable.
How has this been tested?
app.toml.fnsaddomain::1317/swagger/#/Screenshots (if appropriate):
Checklist:
CHANGELOG.md