build: rearrange Dockerfile and Makefile commands #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
- remove `./networks/local/finschianode/Dockerfile` - move from `./builders/Dockerfile.static` to `networks/local/finschianode/Dockerfile` - remove `./networks/Makefile` - remove `./contrib/Dockerfile.test` - remove unused commands in Makefile - `build-docker-finschianode` - `test-docker` - `test-docker-push` Signed-off-by: zemyblue <zemyblue@gmail.com>
- build-contract-tests-hooks - include contrib/devtools/Makefile Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
zemyblue
requested review from
torao,
0Tech,
dudong2,
shiki-tak,
loin3 and
jaeseung-bae
0Tech
reviewed
Jul 14, 2023
Signed-off-by: zemyblue <zemyblue@gmail.com>
And change the property of Makefile from `ARCH` to `TARGET_ARCH`, and add new `ARCH` as new meaning Signed-off-by: zemyblue <zemyblue@gmail.com>
I combined |
jaeseung-bae
previously approved these changes
Jul 17, 2023
dudong2
previously approved these changes
Jul 17, 2023
0Tech
reviewed
Jul 18, 2023
…nput Signed-off-by: zemyblue <zemyblue@gmail.com>
0Tech
approved these changes
Jul 18, 2023
Scottbae37
approved these changes
Jul 18, 2023
jaeseung-bae
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #227
Now there are only two
Dockerfilein this repository.Dockerfilein root dirnetworks/local/finschianode/Dockerfilefor localnet multi-node testing.Changes
builders/Dockerfile.static_centos7contrib/Dockerfile.testcontrib/devtools/Makefilenetworks/local/Makefilebuilders/Dockerfile.statictonetworks/local/finschianode/Dockerfilenetworks/local/finschianode/Dockerfiles build-env to be the same as the defaultDockerfile.contrib/devtools/MakefileinMakefile.Removed commands in
Makefilebuild-release-bundle: no used, because the build assets command is changed in feat: compile static binary as release assets and docker image #221.build-docker-finschianode: no used.test-docker: no usedtest-docker-push: no usedbuild-contract-tests-hooks: no usedbuild-reproducible-arm64andbuild-reproducible-amd64: => combined tobuild-reproducible.Motivation and context
There are many unused commands in Makefile.
And there are many Dockerfiles, all with different base docker images and build steps. Unity is needed.
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md