Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modify the way the binary version is set when compiling #388

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jun 11, 2024

Description

  • Modify the way the binary version is set when compiling.
    • if main branch, main-f71e2e77b45e64df1ae8790b61f80b192350d688.
    • if feat/compile_with_tags branch, feat_compile_with_tags-726c33ee7d7aad03cc4c705c97acbffc67b39bd4.
    • if v4.0.0 tag commit, v4.0.0

Motivation and context

When compiled with the following command, v4.0.0 is not output.

git clone https://github.com/Finschia/finschia
cd finschia && git checkout v4.0.0
make install

fnsad version
# HEAD-0d1b05018dc6fa8265f3bc35d9066cbe644c96b3

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue changed the title chore: modify how binary version is defined chore: Modify the way the binary version is set when compiling Jun 12, 2024
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue marked this pull request as ready for review June 12, 2024 06:34
@zemyblue zemyblue self-assigned this Jun 12, 2024
@zemyblue zemyblue merged commit 7d99e17 into Finschia:main Jun 17, 2024
35 checks passed
@zemyblue zemyblue deleted the feat/compile_with_tags branch June 17, 2024 00:17
mergify bot pushed a commit that referenced this pull request Jun 17, 2024
* chore: modify how binary version is defined

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: update changelog

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
(cherry picked from commit 7d99e17)

# Conflicts:
#	CHANGELOG.md
zemyblue added a commit that referenced this pull request Jun 24, 2024
…ort #388) (#390)

* chore: Modify the way the binary version is set when compiling (#388)

* chore: modify how binary version is defined

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: update changelog

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
(cherry picked from commit 7d99e17)

# Conflicts:
#	CHANGELOG.md

* chore: modify subnet of localnet for docker-compose.yml

Signed-off-by: zemyblue <zemyblue@gmail.com>

* fix: conflict

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: zemyblue <zemyblue@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants