Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply finschia-sdk 0.49.1 #395

Merged
merged 12 commits into from
Jun 25, 2024
Merged

feat: Apply finschia-sdk 0.49.1 #395

merged 12 commits into from
Jun 25, 2024

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Jun 25, 2024

Description

closes: #XXXX

  • Bump Go from 1.20 to 1.22
  • Update outdated go pkgs
  • Update outdated github actions
  • Remove rosetta
  • Apply the same lint rules as finschia-sdk

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@tkxkd0159 tkxkd0159 added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code backport/v4.0.x labels Jun 25, 2024
@tkxkd0159 tkxkd0159 self-assigned this Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 34.28571% with 23 lines in your changes missing coverage. Please review.

Project coverage is 27.80%. Comparing base (f747c3c) to head (190675b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #395       +/-   ##
===========================================
- Coverage   52.19%   27.80%   -24.40%     
===========================================
  Files          10       16        +6     
  Lines        1115     2093      +978     
===========================================
  Hits          582      582               
- Misses        486     1464      +978     
  Partials       47       47               
Files Coverage Δ
ante/ante.go 0.00% <ø> (ø)
app/wasm_filter.go 100.00% <ø> (ø)
cmd/fnsad/cmd/testnet.go 72.30% <100.00%> (ø)
cmd/fnsad/cmd/root.go 15.46% <0.00%> (+0.07%) ⬆️
app/app.go 82.06% <33.33%> (ø)
app/export.go 12.63% <0.00%> (ø)
cmd/fnsad/main.go 0.00% <0.00%> (ø)
cli_test/test_helpers.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@tkxkd0159 tkxkd0159 marked this pull request as ready for review June 25, 2024 08:40
@tkxkd0159 tkxkd0159 changed the title build(deps): bump github.com/Finschia/finschia-sdk from 0.49.0 to 0.49.1 feat: Apply finschia-sdk 0.49.1 Jun 25, 2024
jaeseung-bae
jaeseung-bae previously approved these changes Jun 25, 2024
@zemyblue
Copy link
Member

Please check goreleaser.yaml and make release.

@zemyblue
Copy link
Member

Please check goreleaser.yaml and make release.

Please apply following diff to fix gorelease error.
gorelease error is occurred by gorelease version is updated to v2.

diff --git a/.goreleaser.yml b/.goreleaser.yml
index 8d770a3..4b26a0f 100644
--- a/.goreleaser.yml
+++ b/.goreleaser.yml
@@ -1,5 +1,7 @@
 project_name: fnsad
 
+version: 2
+
 env:
   - CGO_ENABLED=1
 
@@ -108,5 +110,3 @@ checksum:
 snapshot:
   name_template: SNAPSHOT-{{ .Commit }}
 
-changelog:
-  skip: false
diff --git a/Makefile b/Makefile
index da348ce..a05cc2a 100644
--- a/Makefile
+++ b/Makefile
@@ -310,7 +310,7 @@ release-dry-run:
 		release \
 		--clean \
 		--release-notes ./RELEASE_NOTE.md \
-		--skip-publish
+		--skip=publish
 
 release-snapshot:
 	docker run \
@@ -326,7 +326,7 @@ release-snapshot:
 		--clean \
 		--release-notes ./RELEASE_NOTE.md \
 		--snapshot \
-		--skip-validate \
-		--skip-publish
+		--skip=validate \
+		--skip=publish
 
 .PHONY: release release-dry-run release-snapshot

Signed-off-by: zemyblue <zemyblue@gmail.com>
Copy link
Contributor

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue self-requested a review June 25, 2024 11:39
@zemyblue zemyblue enabled auto-merge (squash) June 25, 2024 11:39
@zemyblue zemyblue merged commit a628fb2 into main Jun 25, 2024
44 checks passed
@zemyblue zemyblue deleted the bump-fnsa-sdk-0491 branch June 25, 2024 11:40
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
* Bump Go from 1.20 to 1.22

* Use alpine 1.18

* Update github actions

* Update go deps

* Bump finschia-sdk, wasmd, ibc-go

* Update linter rules

* remove grpc-web

* lint

* Revise make format command

* Add CHANGELOG

* fix: goreleaser error

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: zemyblue <zemyblue@gmail.com>
(cherry picked from commit a628fb2)

# Conflicts:
#	.github/workflows/lint.yml
#	.github/workflows/tests.yml
#	CHANGELOG.md
#	go.mod
#	go.sum
zemyblue added a commit that referenced this pull request Jun 25, 2024
* feat: Apply finschia-sdk 0.49.1 (#395)

* Bump Go from 1.20 to 1.22

* Use alpine 1.18

* Update github actions

* Update go deps

* Bump finschia-sdk, wasmd, ibc-go

* Update linter rules

* remove grpc-web

* lint

* Revise make format command

* Add CHANGELOG

* fix: goreleaser error

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: zemyblue <zemyblue@gmail.com>
(cherry picked from commit a628fb2)

# Conflicts:
#	.github/workflows/lint.yml
#	.github/workflows/tests.yml
#	CHANGELOG.md
#	go.mod
#	go.sum

* fix: conflict error

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: Jaeseung Lee <41176085+tkxkd0159@users.noreply.github.com>
Co-authored-by: zemyblue <zemyblue@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v4.0.x dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants