Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply finschia-sdk 0.49.1 (backport #395) #398

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 25, 2024

Description

closes: #XXXX

  • Bump Go from 1.20 to 1.22
  • Update outdated go pkgs
  • Update outdated github actions
  • Remove rosetta
  • Apply the same lint rules as finschia-sdk

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

This is an automatic backport of pull request #395 done by [Mergify](https://mergify.com).

* Bump Go from 1.20 to 1.22

* Use alpine 1.18

* Update github actions

* Update go deps

* Bump finschia-sdk, wasmd, ibc-go

* Update linter rules

* remove grpc-web

* lint

* Revise make format command

* Add CHANGELOG

* fix: goreleaser error

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: zemyblue <zemyblue@gmail.com>
(cherry picked from commit a628fb2)

# Conflicts:
#	.github/workflows/lint.yml
#	.github/workflows/tests.yml
#	CHANGELOG.md
#	go.mod
#	go.sum
@mergify mergify bot requested a review from tkxkd0159 as a code owner June 25, 2024 11:41
@mergify mergify bot added the conflicts label Jun 25, 2024
Copy link
Author

mergify bot commented Jun 25, 2024

Cherry-pick of a628fb2 has failed:

On branch mergify/bp/release/v4.0.x/pr-395
Your branch is up to date with 'origin/release/v4.0.x'.

You are currently cherry-picking commit a628fb2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/check-generated.yml
	modified:   .github/workflows/ci-smart-contract.yml
	modified:   .github/workflows/docker.yml
	modified:   .github/workflows/e2e-ibc.yml
	deleted:    .github/workflows/format.yml
	modified:   .github/workflows/sims.yml
	modified:   .golangci.yml
	modified:   .goreleaser.yml
	modified:   CONTRIBUTING.md
	modified:   Dockerfile
	modified:   Makefile
	modified:   README.md
	modified:   ante/ante.go
	modified:   ante/ante_test.go
	modified:   app/app.go
	modified:   app/app_test.go
	modified:   app/export.go
	modified:   app/genesis_account_test.go
	modified:   app/wasm_filter.go
	modified:   app/wasm_filter_test.go
	modified:   cli_test/cli_test.go
	modified:   cli_test/test_helpers.go
	modified:   cmd/fnsad/cmd/genaccounts_test.go
	modified:   cmd/fnsad/cmd/root.go
	modified:   cmd/fnsad/cmd/root_test.go
	modified:   cmd/fnsad/cmd/testnet.go
	modified:   cmd/fnsad/cmd/testnet_test.go
	modified:   cmd/fnsad/main.go
	modified:   docs/finschia-tutorials/installation.md
	modified:   init_multi.sh
	modified:   interchaintest/go.mod
	modified:   networks/local/finschianode/Dockerfile

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/lint.yml
	both modified:   .github/workflows/tests.yml
	both modified:   CHANGELOG.md
	both modified:   go.mod
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: zemyblue <zemyblue@gmail.com>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 34.28571% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v4.0.x@8189c56). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release/v4.0.x     #398   +/-   ##
=================================================
  Coverage                  ?   27.80%           
=================================================
  Files                     ?       16           
  Lines                     ?     2093           
  Branches                  ?        0           
=================================================
  Hits                      ?      582           
  Misses                    ?     1464           
  Partials                  ?       47           
Files Coverage Δ
ante/ante.go 0.00% <ø> (ø)
app/wasm_filter.go 100.00% <ø> (ø)
cmd/fnsad/cmd/testnet.go 72.30% <100.00%> (ø)
cmd/fnsad/cmd/root.go 15.46% <0.00%> (ø)
app/app.go 82.06% <33.33%> (ø)
app/export.go 12.63% <0.00%> (ø)
cmd/fnsad/main.go 0.00% <0.00%> (ø)
cli_test/test_helpers.go 0.00% <0.00%> (ø)

@zemyblue zemyblue merged commit 9e1d862 into release/v4.0.x Jun 25, 2024
43 checks passed
@zemyblue zemyblue deleted the mergify/bp/release/v4.0.x/pr-395 branch June 25, 2024 12:04
@zemyblue zemyblue mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants