feat: Implement Call by tx and Call by Query
#37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -449,6 +450,60 @@ | |||
| return data, nil | |||
| } | |||
|
|
|||
| func (k Keeper) executeCallablePoint(ctx sdk.Context, contractAddress sdk.AccAddress, argsEv []byte, callablePointName string) ([]byte, error) { | |||
| defer func(begin time.Time) { k.metrics.ExecuteElapsedTimes.Observe(time.Since(begin).Seconds()) }(time.Now()) | |||
Check warning
Code scanning / CodeQL
Calling the system time
dudong2
reviewed
Apr 24, 2023
Comment on lines
+24
to
+25
| WasmModuleEventTypeForCallablePoint = "wasm-callable_point" | ||
| CustomContractEventPrefixForCallablePoint = "wasm-callable_point-" |
There was a problem hiding this comment.
How about moving the two lines up to match the convention of the existing code?
Kynea0b
changed the title
Call by tx or Call by Query
Kynea0b
changed the title
Call by tx or Call by QueryCall by tx and Call by Query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of this issue.
Finschia/cosmwasm#252
This pr uses vm.CallCallablePoint fun of the wasmvm pr. So this updated after it is merged.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(This PR does not change the API)