-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement CallCallablePoint to VM #97
Conversation
9eb6459
to
f9a5546
Compare
f9a5546
to
bd4e14e
Compare
api/lib.go
Outdated
// name: Serialized string | ||
// args: Serialized [][]byte | ||
// callstack: Serialized []string | ||
// returned used_gas: without instantiation cost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does used_gas
refer to the name of the variable? If so, isn't it gasUsed
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to add a test case when the argument isReadonly = true?
postscript: This has been addressed here. Thanks.
- fix to cost gas even if call callable point fails because of permission. - add a test for it - build libwasmvm
Description
This PR uses Finschia/cosmwasm#272 so updated after it is merged.
This PR implements CallCallablePoint to VM.
This calls a callable point (dynamic linked callee function).
This is a part of Finschia/cosmwasm#273.
Finschia/cosmwasm#273 is solved after this PR is merged and API for rust using CallCallablePoint is implemented.
Types of changes
Checklist