Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/add typing #74

Merged
merged 13 commits into from
Feb 16, 2024
Merged

Refactor/add typing #74

merged 13 commits into from
Feb 16, 2024

Conversation

GustaafL
Copy link
Collaborator

@GustaafL GustaafL commented Feb 9, 2024 •
edited
Loading

Adds mypy to the pre-commit and static typing to the project.

This also drops support for Python 3.9 as it does not support certain types of typing.

GustaafL and others added 7 commits February 7, 2024 08:49
refactor(client): Add static typing
4f50669 
Signed-off-by: GustaafL <guus@seita.nl>
refactor(client): Add error checking for wrong content type
698cb96 
Signed-off-by: GustaafL <guus@seita.nl>
refactor(client): type client.py
e1bf119 
Signed-off-by: GustaafL <guus@seita.nl>
refactor(cem): type as much some of the code
eb6d23f 
Signed-off-by: GustaafL <guus@seita.nl>
feat(mypy): add mypy to pre-commit checks
65a95b6 
Signed-off-by: GustaafL <guus@seita.nl>
refactor(typing): add types for constraints and async parts
4a85e95 
Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL
Update ci.yml
1aa78d7 
Signed-off-by: Guus Linzel <41048720+GustaafL@users.noreply.github.com>
victorgarcia98
victorgarcia98 requested changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on 💯

Still, I have to test if there is any breaking.. I don't think so but just in case

src/flexmeasures_client/client.py Outdated Show resolved Hide resolved
src/flexmeasures_client/client.py Outdated Show resolved Hide resolved
src/flexmeasures_client/client.py Show resolved Hide resolved
src/flexmeasures_client/s2/cem.py Outdated Show resolved Hide resolved
tests/test_client.py Outdated Show resolved Hide resolved
GustaafL added 4 commits February 15, 2024 11:39
refactor(tests): remove commented code
9ecc44f 
Signed-off-by: GustaafL <guus@seita.nl>
refactor(errors): only use message in ContentTypeError
c2d80b3 
Signed-off-by: GustaafL <guus@seita.nl>
refactor(errors): raise specific errors when validating client inputs
6524c7b 
Signed-off-by: GustaafL <guus@seita.nl>
refactor(cem): Logger typing changed to avoid accidental sharing
7d56cd2 
Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL
Copy link
Collaborator Author

Can you check out the changes made to the post_init function in client.py. I've made more changes that were requested for HA.

GustaafL and others added 2 commits February 16, 2024 15:08
refactor(test): import future annotations
d808e84 
Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL
Update ci.yml
e31c59d 
Signed-off-by: Guus Linzel <41048720+GustaafL@users.noreply.github.com>
victorgarcia98
victorgarcia98 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎆

@GustaafL GustaafL merged commit f718fa6 into main Feb 16, 2024
6 checks passed
@GustaafL GustaafL deleted the refactor/add-typing branch February 16, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorgarcia98 victorgarcia98 victorgarcia98 approved these changes

@Flix6x Flix6x Awaiting requested review from Flix6x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GustaafL @victorgarcia98