Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id check to auto checker #47

Open
jjw24 opened this issue May 7, 2021 · 5 comments
Open

Add id check to auto checker #47

jjw24 opened this issue May 7, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@jjw24
Copy link
Member

jjw24 commented May 7, 2021

id needs to be unique as is used for matching existing plugin to download/update. Since this info is manually added into plugin.json, let's enforce it with auto checker here.

Need to also take into consideration of default flow launcher plugins' ids as well.

@jjw24 jjw24 added the enhancement New feature or request label May 7, 2021
@Zeroto521 Zeroto521 self-assigned this Jul 6, 2021
@jjw24
Copy link
Member Author

jjw24 commented Jul 26, 2021

id needs to be unique as is used for matching existing plugin to download/update. Since this info is manually added into plugin.json, let's enforce it with auto checker here.

Done by #50

@jjw24
Copy link
Member Author

jjw24 commented Jul 26, 2021

I didnt close this because the part where we include flow's default plugin ids as well is not done. This helps if anyone would copy those plugins as a starter but forgets to change the id, or this is overkill?

@Zeroto521
Copy link
Member

Zeroto521 commented Aug 26, 2021

Base on #71, there also need to sync upstream plugin id to manifest .

Daily update Id is fine. But how to handle this condition. Upstream plugin id was changed to new one and this new id was already in manifest.

@jjw24
Copy link
Member Author

jjw24 commented Aug 26, 2021

No, if u look at the pr, the ID submitted was different to the repo at the very start.

So we just need to validate on new plugin submission to check against the id in the plugin repo. ID is the unique identifier so should never change after first init.

@Zeroto521
Copy link
Member

I forget once a plugin id is changed flow would treat that plugin to a new plugin.
When above condition happens id should be updated by plugin owner not us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants