CLN, CI: all scripts and configs in one #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taooceros
reviewed
Jun 11, 2021
Zeroto521
commented
Jun 12, 2021
taooceros
reviewed
Jun 14, 2021
|
It's ready to merge. |
|
@Zeroto521 @jjw24 After the merge of #57 , these pr won't be tested, but the requirement still exist. Do you know how to remove that? |
discuss this at #58 |
|
Sorry I have not been looking at this PR, I think @taooceros you have right? Let me know if it's good to go and I will manually merge it |
|
i have changed target branch and doubled checked changes are the same. |
|
it changed to plugin_api_v2 branch too. |
|
Sorry haven't got time to double check this PR. I think it is ready to merge? |
taooceros
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is used to store plugins information.
So helper script should not place at the top level of the project.
With more helper scripts come up, we better put them in another place.