Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix General Converter mismatched ID #71

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Aug 25, 2021

General Converter's submitted ID is not the same as what's in the repo. This fixes it up.

Need to also add validation to check against this. #47

@jjw24 jjw24 added the bug Something isn't working label Aug 25, 2021
@jjw24 jjw24 requested a review from deefrawley August 25, 2021 22:48
@jjw24 jjw24 self-assigned this Aug 25, 2021
@deefrawley
Copy link
Member

This would probably explain why it wasn't updating yesterday after the merge (I thought it was something I had borked when testing - no idea how it got a mismtached ID).

@deefrawley
Copy link
Member

Oh - it's just a case and dashes format thing....

@deefrawley deefrawley merged commit 9d9afe4 into plugin_api_v2 Aug 25, 2021
@deefrawley deefrawley deleted the fix_genconverter_mismatched_id branch August 25, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants