Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If Memory constraints passed to launcher use them to set max-old-space size for npm install #194

Open
hardillb opened this issue Nov 19, 2023 · 0 comments
Open

If Memory constraints passed to launcher use them to set max-old-space size for npm install #194

hardillb opened this issue Nov 19, 2023 · 0 comments
Labels
feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do

Comments

@hardillb
Copy link
Contributor

Description

When starting a suspended instance that the user has been adding nodes to over time it may fail because npm consumes more memory than the container allows (k8s/docker)

On these platforms we are now passing the memory/cpu limits to the nr-launcher as a env var, we should be able to use this to set the NODE_OPTIONS env var for the npm process to limit the memory used. This should stop npm getting killed by the container manager.
@hardillb hardillb added feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do labels Nov 19, 2023
hardillb added a commit that referenced this issue Nov 20, 2023
@hardillb
Add NODE_OPTIONS env var to npm install
7f3e248 
part of #194
@hardillb hardillb mentioned this issue Nov 20, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do
Projects
☁️ Product Planning
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hardillb