Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NODE_OPTIONS env var to npm install #195

Closed
wants to merge 1 commit into from
Closed

Conversation

hardillb
Copy link
Contributor

part of #194

Description

Set the max-old-space for npm when doing the initial install to try and prevent the process getting killed by the OOM reaper (or at least try and limit heap size to with in the bounds)

Related Issue(s)

part of #194

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Nov 20, 2023
@hardillb
Copy link
Contributor Author

I need to test this a bit more on Docker and my local Kube, but it should help.

@hardillb
Copy link
Contributor Author

Deleting because

$NODE_OPTIONS="--max-old-space=256" npm install 
/usr/bin/node-18: --max-old-space= is not allowed in NODE_OPTIONS

@hardillb hardillb closed this Nov 22, 2023
@hardillb hardillb deleted the limit-npm-old-space branch November 22, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant