fix: add package parameter to generated asset provider method #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orevial
commented
Feb 22, 2023
| @@ -570,7 +570,16 @@ class AssetGenImage { | |||
| ); | |||
| } | |||
|
|
|||
| ImageProvider provider() => AssetImage(_assetName); | |||
| ImageProvider provider({ | |||
There was a problem hiding this comment.
This is the one and only real change :
providermethod now sets the package if the flag is enabledprovidermethod now accepts arguments that mirror theAssetImageconstructor
Note that the rest of the files are only updates of tests and examples
alexconsel
approved these changes
Feb 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 20 20
Lines 693 693
=======================================
Hits 681 681
Misses 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3 tasks
|
@orevial |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #360
What does this change?
Make generated Image.provider method accepts an optional package name, which default to current package when using
package_parameter_enabledflagFixes #360 🎯
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run unit:test)melos run formatto automatically apply formatting)