Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing package on AssetGenImage.provider() #365

Closed
wants to merge 1 commit into from

Conversation

yongjhih
Copy link

@yongjhih yongjhih commented Mar 8, 2023

What does this change?

Generated AssetGenImage.provider() => AssetImage(_assetName); should come with package that's consistent with AssetGenImage.image().

AssetGenImage.provider() => AssetImage(_assetName, package: $package);

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ensure the tests (melos run unit:test)
  • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)

Screen Shot 2023-03-08 at 6 39 03 PM

Screen Shot 2023-03-08 at 6 38 46 PM

@yongjhih yongjhih requested a review from wasabeef as a code owner March 8, 2023 10:37
@yongjhih
Copy link
Author

yongjhih commented Mar 8, 2023

Duplicates to #361

@yongjhih yongjhih closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant